Move "Convert to regular blocks" button to block toolbar. #24066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
added
[Type] Enhancement
|
Size Change: +3 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
ZebulanStanphill
force-pushed
the
update/move-convert-to-regular-blocks-to-toolbar
branch
from
0ef1876
to
70addc8
Compare
ZebulanStanphill
requested review from
ajitbohra,
nerrad,
ntwb,
Soean and
talldan
as code owners
talldan
approved these changes
Jul 28, 2020
There was a problem hiding this comment.
Looks great! Thanks for picking this up @ZebulanStanphill 🎉
talldan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #8403.
This PR moves the option to convert an instance of a reusable block to just regular blocks. It moves it out of the block toolbar's "More options" menu to the top-level block toolbar. Since this action is specific to the "Reusable Block" block, it makes more sense to appear here rather than hidden in the menu, and it makes the button a lot more visible than before.
It also changes the wording of the button from "Convert to Regular Block" to "Convert to regular blocks", to be more consistent with other buttons that use sentence case.
How has this been tested?
I tested to make sure that creating reusable blocks and converting instances of them back to regular blocks both still worked.
It's worth noting that the buggy behavior described in #22832 continues to exist, but this bug does not affect the behavior of the button, nor does it prevent it from appearing.
Screenshots
Before
After
Checklist: