Create Block: Use the same version for stylesheets and scripts #23137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
|
I like this idea. Out of curiosity, did you test if the version (hash) changes when only CSS assets get modified? That would be the only concern here. |
I just tested it again and the hash appears to only change when a CSS file which is not |
I tested it locally, it looks like this version (webpack hash) generated is based on the content of JS file. We would need to find a way to create an asset file with the version that is targeting the content of CSS file. |
I'm observing that issue as well. So it's only |
|
Closing this for now. There should be a better/more reliable way to generate the version of a stylesheet. See also #22519. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since CSS and JS files are generated by the same build task at the same time we can also use the same version. This replaces the
filemtime()call with the version provided by the assets file.This prevents asking the file system for data which may be even unreliable when used in server setups with horizontal scaling.