Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat: Conditionally filter editor settings for image dimensions #20939

Merged
merged 3 commits into from
Mar 17, 2020

Commits on Mar 16, 2020

  1. Configuration menu
    Copy the full SHA
    7509f99 View commit details
    Browse the repository at this point in the history
  2. Compat: Use empty to detect imageSizes

    `is_array` still warns if not set. Coincidentally helps avoid an unnecessary call to wp_get_registered_image_subsizes when there's no sizes to work with. One difference is that imageDimensions would not be set unless imageSizes is non-empty. But if the idea is for imageDimensions to be dependent upon imageSizes here, it's a sensible caveat.
    aduth committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    78c90b9 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2020

  1. Framework: Convert comment to multiline

    Resolves lint errors
    aduth committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    ea5a052 View commit details
    Browse the repository at this point in the history