-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block library: Use block.json consistently for FSE blocks #20717
Conversation
Size Change: 0 B Total Size: 864 kB ℹ️ View Unchanged
|
72b893e
to
eb177c1
Compare
eb177c1
to
d21cc57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
I see failures on Travis:
It looks like an issue with |
Previously: #19786
This pull request seeks to update block registration for a number of full-site editing blocks to match that of other server-registered blocks leveraging
block.json
. As noted in #19786, when a block registers settings both in PHP and viablock.json
, it should be implemented as a merge of the PHP implementation of the JSON metadata. This also has the benefit of eliminating some duplication that currently exists between PHP implementation andblock.json
("Post Date" and "Post Excerpt" block attributes definition). An exception was made for "Post Comments Count" blockclassName
attribute, which is registered only in PHP, as it's expected this would eventually be handled as part of the implementation of block "supports" server-side (e.g. #18414, specifically c7cded6).Testing Instructions:
There should be no regressions in the display or behavior of full-site editing blocks.
Check the source and ensure that
wp.blocks.unstable__bootstrapServerSideBlockDefinitions
call properly propagates all updated blocks and their definitions.