Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Fix BlockCaption padding visibility #20535

Merged
merged 2 commits into from
Mar 4, 2020

Conversation

jbinda
Copy link
Contributor

@jbinda jbinda commented Feb 28, 2020

Description

According to this issue this PR fixes extra spaces added below Image.

The issue is connected with the BlockCaption. See this comment for more details and this PR which bring this component.

I have noticed that it also affect Gallery and Video blocks because under the media it also uses BlockCaption component.

Please also refer to:
Related gutenberg-mobile PR
Related gutenberg-mobile issue

comment with investigation
PR on Caption refactor

Presented solution is the simplest one. However we might also consider the one I posted in the comment with investigation which is:

move that padding value to styles and connect with $block-selected-to-content variable which ensure to always align the padding with rest of the content

How has this been tested?

  1. Start with below code in initial-html
/**
 * @format
 * @flow
 */

export default `
<!-- wp:group -->
<div class="wp-block-group"><div class="wp-block-group__inner-container"><!-- wp:image {"id":1,"sizeSlug":"large"} -->
<figure class="wp-block-image size-large"><img src="https://cldup.com/cXyG__fTLN.jpg" alt="" class="wp-image-1"/></figure>
<!-- /wp:image -->

<!-- wp:media-text -->
<div class="wp-block-media-text is-stacked-on-mobile"><figure class="wp-block-media-text__media"></figure><div class="wp-block-media-text__content"><!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph --></div></div>
<!-- /wp:media-text -->

<!-- wp:group -->
<div class="wp-block-group"><div class="wp-block-group__inner-container"><!-- wp:image -->
<figure class="wp-block-image"><img alt=""/></figure>
<!-- /wp:image --></div></div>
<!-- /wp:group -->

<!-- wp:video {"id":2} -->
<figure class="wp-block-video"><video controls src="https://i.cloudup.com/YtZFJbuQCE.mov"></video></figure>
<!-- /wp:video -->

<!-- wp:gallery {"ids":[1,3]} -->
<figure class="wp-block-gallery columns-2 is-cropped"><ul class="blocks-gallery-grid"><li class="blocks-gallery-item"><figure><img src="https://cldup.com/cXyG__fTLN.jpg" data-id="1" class="wp-image-1"/></figure></li><li class="blocks-gallery-item"><figure><img src="https://cldup.com/cXyG__fTLN.jpg" data-id="3" class="wp-image-3"/></figure></li></ul></figure>
<!-- /wp:gallery --></div></div>
<!-- /wp:group -->


`;
  1. Change selection between blocks
  2. Observe that the extra space is not visible anymore under the mentioned blocks (it is easier to observe when the Goup block which holds the block is selected - then the children got the dashed border style)

To replicate the previous behaviour fix the padding value to 12 in BlockCaption component. Then after proceeding with above you will notice extra space below mentioned blocks.

Screenshots

Before:

After:

Types of changes

Bug fix: Remove extra padding below media in Video, Image and Gallery block.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@jbinda jbinda added [Type] Bug An existing feature does not function as intended [Block] Image Affects the Image Block [Block] Gallery Affects the Gallery Block - used to display groups of images [Block] Video Affects the Video Block labels Feb 28, 2020
@jbinda jbinda self-assigned this Feb 28, 2020
@github-actions
Copy link

github-actions bot commented Feb 28, 2020

Size Change: -349 B (0%)

Total Size: 865 kB

Filename Size Change
build/block-editor/index.js 105 kB +116 B (0%)
build/block-editor/style-rtl.css 10.5 kB -24 B (0%)
build/block-editor/style.css 10.5 kB -20 B (0%)
build/block-library/editor-rtl.css 7.4 kB -263 B (3%)
build/block-library/editor.css 7.4 kB -264 B (3%)
build/block-library/index.js 116 kB +22 B (0%)
build/block-library/style-rtl.css 7.51 kB +17 B (0%)
build/block-library/style.css 7.51 kB +17 B (0%)
build/components/style-rtl.css 15.6 kB +36 B (0%)
build/components/style.css 15.5 kB +38 B (0%)
build/edit-post/index.js 90.9 kB -2 B (0%)
build/edit-post/style-rtl.css 8.53 kB -13 B (0%)
build/edit-post/style.css 8.53 kB -12 B (0%)
build/editor/index.js 44.6 kB +21 B (0%)
build/editor/style-rtl.css 3.98 kB -25 B (0%)
build/editor/style.css 3.98 kB -25 B (0%)
build/rich-text/index.js 14.3 kB +32 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.01 kB 0 B
build/annotations/index.js 3.43 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.02 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.6 kB 0 B
build/components/index.js 191 kB 0 B
build/compose/index.js 5.76 kB 0 B
build/core-data/index.js 10.5 kB 0 B
build/data-controls/index.js 1.03 kB 0 B
build/data/index.js 8.22 kB 0 B
build/date/index.js 5.37 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.06 kB 0 B
build/edit-site/index.js 4.63 kB 0 B
build/edit-site/style-rtl.css 2.51 kB 0 B
build/edit-site/style.css 2.51 kB 0 B
build/edit-widgets/index.js 4.42 kB 0 B
build/edit-widgets/style-rtl.css 2.59 kB 0 B
build/edit-widgets/style.css 2.58 kB 0 B
build/editor/editor-styles-rtl.css 325 B 0 B
build/editor/editor-styles.css 327 B 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.6 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.92 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.48 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.68 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 4.85 kB 0 B
build/notices/index.js 1.57 kB 0 B
build/nux/index.js 3.02 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.49 kB 0 B
build/priority-queue/index.js 780 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/server-side-render/index.js 2.54 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4 kB 0 B
build/viewport/index.js 1.61 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@jbinda jbinda merged commit 2446adb into master Mar 4, 2020
@jbinda jbinda deleted the rnmobile/fix-caption-padding-visibility branch March 4, 2020 13:55
@github-actions github-actions bot added this to the Gutenberg 7.7 milestone Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Block] Image Affects the Image Block [Block] Video Affects the Video Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants