-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Fix BlockCaption padding visibility #20535
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbinda
added
[Type] Bug
An existing feature does not function as intended
[Block] Image
Affects the Image Block
[Block] Gallery
Affects the Gallery Block - used to display groups of images
[Block] Video
Affects the Video Block
labels
Feb 28, 2020
2 tasks
Size Change: -349 B (0%) Total Size: 865 kB
ℹ️ View Unchanged
|
dratwas
reviewed
Mar 2, 2020
packages/block-editor/src/components/block-caption/index.native.js
Outdated
Show resolved
Hide resolved
dratwas
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Gallery
Affects the Gallery Block - used to display groups of images
[Block] Image
Affects the Image Block
[Block] Video
Affects the Video Block
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to this issue this PR fixes extra spaces added below Image.
The issue is connected with the
BlockCaption
. See this comment for more details and this PR which bring this component.I have noticed that it also affect
Gallery
andVideo
blocks because under the media it also usesBlockCaption
component.Please also refer to:
Related gutenberg-mobile PR
Related gutenberg-mobile issue
comment with investigation
PR on Caption refactor
Presented solution is the simplest one. However we might also consider the one I posted in the comment with investigation which is:
How has this been tested?
initial-html
To replicate the previous behaviour fix the padding value to 12 in
BlockCaption
component. Then after proceeding with above you will notice extra space below mentioned blocks.Screenshots
Before:
After:
Types of changes
Bug fix: Remove extra padding below media in Video, Image and Gallery block.
Checklist: