Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Editor: LinkControl: Incorporate settings in edit state #20052

Merged
merged 16 commits into from
Feb 10, 2020
Merged

Block Editor: LinkControl: Incorporate settings in edit state #20052

merged 16 commits into from
Feb 10, 2020

Commits on Feb 6, 2020

  1. Block Editor: LinkControl: Incorporate settings in edit state

    @aduth
    aduth committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    5722249 View commit details
    Browse the repository at this point in the history

  2. Block Editor: LinkControl: Add forceIsEditingLink prop support

    @aduth
    aduth committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    40e393f View commit details
    Browse the repository at this point in the history

  3. Format Library: Force LinkControl editing state when adding link

    @aduth
    aduth committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    f1ef136 View commit details
    Browse the repository at this point in the history

  4. E2E Tests: Update end-to-end tests for expected link keyboard workflow

    @aduth
    aduth committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    4f92778 View commit details
    Browse the repository at this point in the history

  5. Revert "Block Editor: LinkControl: Incorporate settings in edit state" 

    This reverts commit 5596566.
    @aduth
    aduth committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    3041e5e View commit details
    Browse the repository at this point in the history

  6. Block Library: LinkControl: Always show settings drawer

    @aduth
    aduth committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    5a804dc View commit details
    Browse the repository at this point in the history

  7. Format Library: Avoid shifting focus back to paragraph on toggle

    @aduth
    aduth committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    74d659b View commit details
    Browse the repository at this point in the history

  8. Components: Extract spinner size as base variable 

    Allow for reuse in computing dimensions in other stylesheets
    @aduth
    aduth committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    4d43e07 View commit details
    Browse the repository at this point in the history

  9. Block Editor: LinkControl: Add Submit button as action

    @aduth
    aduth committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    5ff4106 View commit details
    Browse the repository at this point in the history

  10. Block Editor: LinkControl: Remove Reset button

    @aduth
    aduth committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    74dd122 View commit details
    Browse the repository at this point in the history

  11. Block Editor: LinkControl: Remove disabled from submit button 

    Instead inherit that the form cannot be submitted since the rendered URLInput will apply a `required` attribute, preventing submission of the form, while still displaying the associated help text "You must fill out this field"
    @aduth
    aduth committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    770e72d View commit details
    Browse the repository at this point in the history

  12. Block Editor: LinkControl: Pad horizontally to match vertical

    @aduth
    aduth committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    b328d20 View commit details
    Browse the repository at this point in the history

  13. Format Library: Return paragraph selection on link edit cancel

    @aduth
    aduth committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    15f4d08 View commit details
    Browse the repository at this point in the history

  14. Block Editor: LinkControl: Infer absence of value setting as unchecked

    @aduth
    aduth committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    d4d8919 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2020

  1. Format Library: Hold "Open in New Tab" during insert

    @aduth
    aduth committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    8d9fe07 View commit details
    Browse the repository at this point in the history

  2. Format Library: Refactor, comment inline link state flow

    @aduth
    aduth committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    ae596cd View commit details
    Browse the repository at this point in the history