Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor URLInput component #19551

Closed
wants to merge 5 commits into from
Closed

Refactor URLInput component #19551

wants to merge 5 commits into from

Commits on Jan 10, 2020

  1. Refactor URLInput into separate presentational and connected componen… 

    …ts. Separate suggestions into distinct components.
    @talldan
    talldan committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    42fae5d View commit details
    Browse the repository at this point in the history

  2. Consolidate BaseURLInput and BaseURLInputWithSuggestions

    @talldan
    talldan committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    67c2966 View commit details
    Browse the repository at this point in the history

  3. Tidy up input props

    @talldan
    talldan committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    81f1485 View commit details
    Browse the repository at this point in the history

  4. Use useCallback to avoid constant re-fetching of requests

    @talldan
    talldan committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    276e694 View commit details
    Browse the repository at this point in the history

  5. Tidy up shonky component names

    @talldan
    talldan committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    267026f View commit details
    Browse the repository at this point in the history