Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

G2: UI surrounding the editor canvas #19348

Merged
merged 11 commits into from
Feb 20, 2020
Merged

G2: UI surrounding the editor canvas #19348

merged 11 commits into from
Feb 20, 2020

Commits on Feb 20, 2020

  1. G3: UI surrounding editor canvas branch start. 

    - Updates borders for dropdowns, and proceeds to do additional polish work outside the editor canvas.
    @youknowriad
    youknowriad authored and Joen Asmussen committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    56c7243 View commit details
    Browse the repository at this point in the history

  2. General layout polish.

    Joen Asmussen committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    8bf5a34 View commit details
    Browse the repository at this point in the history

  3. Try: Briefly flash footprint on first click.

    Joen Asmussen committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    95a905c View commit details
    Browse the repository at this point in the history

  4. Adjust primary, secondary and tertiary buttons. 

    This will no doubt need additional feedback, and the branch should stay open for a while to gather all those thoughts.

One of the primary reasons for reducing the borders is, similar to tertiary buttons, that they work due to their context, just like how menu ite
ms work in their menu item contexts. This puts a great onus on the implementer to choose the right button for the right context. In that vein, w
e may even want to provide additional buttons, such as a solid background button that isn't primary, for cases where a primary button is insuffi
cient, and a secondary button does not work well enough in the context. An example could be considered the link dialog mocked up here #20007 (comment)
    Joen Asmussen committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    fec0a75 View commit details
    Browse the repository at this point in the history

  5. Polish preview dropdown.

    @jasmussen
    jasmussen authored and Joen Asmussen committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    867b113 View commit details
    Browse the repository at this point in the history

  6. Address feedback: Remove icon from menu, and realign menu.

    @jasmussen
    jasmussen authored and Joen Asmussen committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    9734b48 View commit details
    Browse the repository at this point in the history

  7. Try: tertiary buttons for media placeholder, with tweaks.

    @jasmussen
    jasmussen authored and Joen Asmussen committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    3f82e61 View commit details
    Browse the repository at this point in the history

  8. Polish horizontal nav and text footprint experiment. 

    This moves the flashing footprint indicator to only the paragraph block.
    @jasmussen
    jasmussen authored and Joen Asmussen committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    c218783 View commit details
    Browse the repository at this point in the history

  9. Add mover support for fixed top toolbar

    Jon Q authored and Joen Asmussen committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    7549d46 View commit details
    Browse the repository at this point in the history

  10. Address feedback. 

    - Restore gray sidebar header.
- Use isPrimary for toolbar library button.
- Make inbetweenserter not look primary.
    Joen Asmussen committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    36b58b9 View commit details
    Browse the repository at this point in the history

  11. Fix inserter toggle in different situations

    @youknowriad
    youknowriad committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    9d9d5a5 View commit details
    Browse the repository at this point in the history