Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package: Replace fs-extra with rimraf. #18790

Merged
merged 1 commit into from
Nov 28, 2019

Conversation

epiqueras
Copy link
Contributor

It surfaced in this thread, that we only use fs-extra for its remove function. We already have rimraf which does the same thing, and we need it for its CLI, so it makes sense to replace fs-extra with rimraf and avoid pulling in an extra dependency.

@epiqueras epiqueras added [Type] Build Tooling Issues or PRs related to build tooling [Type] Performance Related to performance efforts labels Nov 27, 2019
@epiqueras epiqueras added this to the Future milestone Nov 27, 2019
@epiqueras epiqueras self-assigned this Nov 27, 2019
@ntwb
Copy link
Member

ntwb commented Nov 28, 2019

Node.js 12.10: Add recursive option to rmdir() in #29168

https://nodejs.org/en/blog/release/v12.10.0/

I don't think we need rimraf at all, this can be achieved with fs.rmdir()

Background reading: https://dev.to/boneskull/recursive-directory-removal-in-node-js-239f

@youknowriad
Copy link
Contributor

@ntwb Oh! I didn't know about that :) Thanks for sharing.

@epiqueras
Copy link
Contributor Author

I didn't use it, because it's still "Stability 1".

Stability: 1 - Experimental. The feature is not subject to Semantic Versioning rules. Non-backward compatible changes or removal may occur in any future release. Use of the feature is not recommended in production environments.

@epiqueras epiqueras merged commit 0536a67 into master Nov 28, 2019
@epiqueras epiqueras deleted the update/replace-fs-extra-with-rimraf branch November 28, 2019 14:17
@youknowriad youknowriad modified the milestones: Future, Gutenberg 7.1 Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling [Type] Performance Related to performance efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants