Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Spacer block in production for the mobile apps #18605

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Enable Spacer block in production for the mobile apps #18605

merged 1 commit into from
Nov 26, 2019

Conversation

geriux
Copy link
Member

@geriux geriux commented Nov 19, 2019 •
edited
Loading

Description

This enables the Spacer block in production for the mobile apps.

Gutenberg Mobile -> wordpress-mobile/gutenberg-mobile#1594

How has this been tested?

WordPress iOS -> wordpress-mobile/WordPress-iOS#12970
WordPress Android -> wordpress-mobile/WordPress-Android#10817

Types of changes

New feature (Mobile)

This was referenced Nov 19, 2019
Closed
Closed
Merged
@geriux geriux marked this pull request as ready for review November 19, 2019 14:03
@geriux geriux requested a review from pinarol November 19, 2019 14:04
@geriux geriux added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Nov 19, 2019
@geriux geriux requested review from SergioEstevao and marecar3 and removed request for pinarol November 20, 2019 10:31
SergioEstevao
SergioEstevao approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

marecar3
marecar3 approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@geriux geriux force-pushed the rnmobile/enable-spacer-block branch from 9622ef1 to 4fe1da3 Compare November 26, 2019 15:30
@geriux geriux changed the base branch from master to rnmobile/release-v1.18.0 November 26, 2019 15:30
@maxme maxme merged commit 2a6bf6c into rnmobile/release-v1.18.0 Nov 26, 2019
@maxme maxme deleted the rnmobile/enable-spacer-block branch November 26, 2019 16:40
maxme added a commit that referenced this pull request Nov 29, 2019
@maxme
[RNMobile] Merge mobile release v1.18.0 back into master (#18804)
db956c4 
* [RNMobile] Enable Spacer block (#18605)

* Fix caption alignemnt on images. (#18818)

* Imagea Size: Force use original image URL when required slug does not exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

@marecar3 marecar3 marecar3 approved these changes

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geriux @SergioEstevao @marecar3 @maxme