Remove iframe and img responsiveness rules. #18281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an alternative, and/or addition to #18240. There is discussion around removing these base styles in favor of letting the theme do the work, and the img and iframe rules have been around for a while but might not be needed. This PR removes both those rules, the other only the iframe which seems to be the most offending.
jasmussen
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
|
Historical context: The The I guess one issue we may experience by removing the styles altogether is that images may overflow beyond the bounds of their block. Depending on how the theme would treat this on the front-end, it might still be the most accurate depiction of the image. |
|
Closed as superseded by #18287 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative, and/or addition to #18240.
There is discussion around removing these base styles in favor of letting the theme do the work, and the img and iframe rules have been around for a while but might not be needed. This PR removes both those rules, the other only the iframe which seems to be the most offending.