Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block: Add text indicating that a menu is loading. #18188

Merged

Conversation

mtias
Copy link
Member

@mtias mtias commented Oct 30, 2019

Display text to indicate a menu is loading.

image

Closes #18179.

@mtias mtias added the [Block] Navigation Affects the Navigation Block label Oct 30, 2019
Copy link
Member

@noisysocks noisysocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we didn't show the spinner when loading a post or page that already has a Navigation block in it. Not a blocker here though.

@noisysocks noisysocks merged commit e43023a into master Oct 31, 2019
@noisysocks noisysocks deleted the update/show-placeholder-text-when-loading-navigation branch October 31, 2019 03:10
@mtias
Copy link
Member Author

mtias commented Oct 31, 2019

It would be nice if we didn't show the spinner when loading a post or page that already has a Navigation block in it.

I agree, I hope this can be minimized to generating a menu for the first time.

@youknowriad youknowriad added this to the Gutenberg 6.9 milestone Nov 11, 2019
@shaunandrews
Copy link
Contributor

Lets continue to improve this message:
#18482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show text placeholder when initializing a menu from scratch
4 participants