Fixes the checkbox appearance #17571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epiqueras
requested changes
Sep 25, 2019
packages/editor/src/components/post-taxonomies/hierarchical-term-selector.js
Outdated
Show resolved
Hide resolved
packages/editor/src/components/post-taxonomies/hierarchical-term-selector.js
Outdated
Show resolved
Hide resolved
packages/editor/src/components/post-taxonomies/hierarchical-term-selector.js
Show resolved
Hide resolved
packages/editor/src/components/post-taxonomies/hierarchical-term-selector.js
Show resolved
Hide resolved
draganescu
requested review from
ajitbohra,
gziolo,
nerrad and
ntwb
as code owners
talldan
reviewed
Sep 27, 2019
|
I've added this to the WP 5.3 Must Have's project, but feel free to remove it if you disagree. |
|
Tests pass, review observations implemented. |
epiqueras
approved these changes
Sep 27, 2019
youknowriad
pushed a commit
that referenced
this pull request
Sep 30, 2019
* Fixes the checkbox appearance * using checkbox control * fixing issues found by review * fix for e2e * fix test selector * fix test selector pretty please * fix test o' c'mon!
youknowriad
pushed a commit
that referenced
this pull request
Sep 30, 2019
* Fixes the checkbox appearance * using checkbox control * fixing issues found by review * fix for e2e * fix test selector * fix test selector pretty please * fix test o' c'mon!
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #17564
How has this been tested?
Tested locally.
Screenshots
Types of changes
Used a
CheckboxControlcomponent for the taxonomy list.Checklist: