Check to ensure focus has intentionally left the wrapped component in withFocusOutside HOC
#17051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… focus Previously there was no check to see whether the blur event occured within the wrapped component. If it occurs within then we do not want to trigger the `handleFocusOutside` callback because (by definition) the focus has not moved outside the wrapped element. This may have been a regression introduced in #16878
getdave
added
the
Needs Technical Feedback
getdave
requested review from
ajitbohra,
gziolo,
jorgefilipecosta and
talldan
as code owners
youknowriad
added
the
[Type] Bug
youknowriad
reviewed
Aug 15, 2019
packages/components/src/higher-order/with-focus-outside/index.js
Outdated
Show resolved
Hide resolved
|
Looks like that there's a lot of failing tests. |
|
Yeh I should look at those tests now. |
Previously we fixed the wrong problem. The actual issue is that previously we were handling document blur events as true “focus outside” events when in fact they should be ignored as if the document is not focused then presumably the user did not intent the blur.
getdave
changed the title
getdave
changed the title
withFocusOutside HOC
youknowriad
reviewed
Aug 19, 2019
There was a problem hiding this comment.
This works as intended but it's not fixing all the issues I hoped it would fix :)
It's not fixing #17042 but it's slightly related.
youknowriad
approved these changes
Aug 19, 2019
I'll take a look at that other bug as I might have some insight now I understand this area of the code better. Thanks for approving review 👍 |
getdave
deleted the
fix/with-focus-outside-properly-check-event-location
branch
donmhico
pushed a commit
to donmhico/gutenberg
that referenced
this pull request
Aug 27, 2019
… `withFocusOutside` HOC (WordPress#17051) * Adds check to determine whether event occured within element trapping focus Previously there was no check to see whether the blur event occured within the wrapped component. If it occurs within then we do not want to trigger the `handleFocusOutside` callback because (by definition) the focus has not moved outside the wrapped element. This may have been a regression introduced in WordPress#16878 * Fix handling blur event when document is not actually focused Previously we fixed the wrong problem. The actual issue is that previously we were handling document blur events as true “focus outside” events when in fact they should be ignored as if the document is not focused then presumably the user did not intent the blur. * Update to test for document loss of focus scenario
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
… `withFocusOutside` HOC (#17051) * Adds check to determine whether event occured within element trapping focus Previously there was no check to see whether the blur event occured within the wrapped component. If it occurs within then we do not want to trigger the `handleFocusOutside` callback because (by definition) the focus has not moved outside the wrapped element. This may have been a regression introduced in #16878 * Fix handling blur event when document is not actually focused Previously we fixed the wrong problem. The actual issue is that previously we were handling document blur events as true “focus outside” events when in fact they should be ignored as if the document is not focused then presumably the user did not intent the blur. * Update to test for document loss of focus scenario
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
… `withFocusOutside` HOC (#17051) * Adds check to determine whether event occured within element trapping focus Previously there was no check to see whether the blur event occured within the wrapped component. If it occurs within then we do not want to trigger the `handleFocusOutside` callback because (by definition) the focus has not moved outside the wrapped element. This may have been a regression introduced in #16878 * Fix handling blur event when document is not actually focused Previously we fixed the wrong problem. The actual issue is that previously we were handling document blur events as true “focus outside” events when in fact they should be ignored as if the document is not focused then presumably the user did not intent the blur. * Update to test for document loss of focus scenario
aduth
reviewed
Mar 13, 2020
| // this blur event thereby leaving focus in place. | ||
| // https://developer.mozilla.org/en-US/docs/Web/API/Document/hasFocus. | ||
| if ( ! document.hasFocus() ) { | ||
| event.preventDefault(); |
There was a problem hiding this comment.
Is this line necessary, or is the fix contained in just avoiding the callback?
Notably, the focus event is not cancellable, so it doesn't seem like this should be doing anything.
See: https://developer.mozilla.org/en-US/docs/Web/API/Element/focus_event
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
withFocusOutsideHOC aims to detect when a focus occurs outside of the wrapped compomnent.Previously there was no check to see whether the blur event occurred within the wrapped component.
If it occurs within then we do not want to trigger the
handleFocusOutsidecallback because (by definition) the focus has not moved outside the wrapped element.This may have been a regression introduced by removal of
react-click-outsidein #16878How has this been tested?
Still working on this.
Types of changes
Bug fix (non-breaking change which fixes an issue
Checklist: