Chrome: Show notices on post save, schedule, update #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
General Interface
mtias
reviewed
Jun 28, 2017
editor/effects.js
Outdated
| 'private': __( 'Post published privately!' ), | ||
| future: __( 'Post schduled!' ), | ||
| }; | ||
| if ( isPublished || publishStatus.indexOf( post.status ) !== -1 ) { |
There was a problem hiding this comment.
Can we add a few comments explaining how we are handling this?
|
Looking good to me. |
mtias
approved these changes
Jun 28, 2017
|
Love it. Ship it. |
youknowriad
force-pushed
the
add/publish-save-notices
branch
from
0ac334f
to
117995c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #967