Refactor Tabel block to use block.json metadata #14863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Task
gziolo
requested review from
ajitbohra,
jorgefilipecosta,
noisysocks,
notnownikki,
Soean,
talldan and
youknowriad
as code owners
gziolo
commented
Apr 8, 2019
| }, | ||
| }; | ||
|
|
||
| function getTableSectionAttributeSchema( section ) { |
There was a problem hiding this comment.
JSON format doesn't allow using functions so it had to be duplicated 3 times.
jorgefilipecosta
approved these changes
Apr 8, 2019
There was a problem hiding this comment.
LGTM 👍 I did not notice any regression during my tests. It is unfortunate that we need to have some duplication because of having nor variables we can reuse in a JSON file but I guess there is not much we can do about it without adding complexity to the block.json solution.
This was referenced Apr 15, 2019
Closed
Closed
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially implements #13693:
name,categoryandattributesinblock.jsontransformsorsaveto their own filesHow has this been tested?
Ensure that File block still works as before.