Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try: Move color and font size from captions to theme #14366

Merged
merged 5 commits into from
Mar 21, 2019

Commits on Mar 21, 2019

  1. Try: Move color and font size from captions to theme

    This PR moves the color and font size styles for captions to a separate CSS file that themes opt in to.
    
    As a reminder, we have style.scss, which contains structural and base styles that are loaded in the editor and the theme.
    There's editor.scss which is only loaded in the editor.
    There's theme.scss, which is loaded in the editor and the theme if the theme opts in to them.
    
    Addresses one item surfaced in #12299 (comment), props @joyously.
    jasmussen committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    aec49f6 View commit details
    Browse the repository at this point in the history
  2. Address feedback.

    jasmussen committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    bc38d62 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    214e84e View commit details
    Browse the repository at this point in the history
  4. Address margin feedback.

    jasmussen committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    b6344ee View commit details
    Browse the repository at this point in the history
  5. Address feedback.

    jasmussen committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    9b84916 View commit details
    Browse the repository at this point in the history