DOM: Limit single tabbable radio input by name #14128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Focus] Accessibility (a11y)
aduth
requested review from
gziolo,
oandregal and
youknowriad
as code owners
afercia
approved these changes
Feb 26, 2019
There was a problem hiding this comment.
From an accessibility perspective, works nicely. Tested on the Visibility panel: tabbing is now constrained within the panel. Wish there was a simpler way to solve it 😬 It's self container. Has test. Brilliant, thanks.
(will leave code review to the author himself 😉)
aduth
force-pushed
the
fix/6988-tabbable-radio-by-name
branch
from
4949c79
to
956cf39
Compare
aduth
force-pushed
the
fix/6988-tabbable-radio-by-name
branch
from
956cf39
to
2809765
Compare
youknowriad
approved these changes
Mar 15, 2019
| @@ -30,6 +35,46 @@ function getTabIndex( element ) { | |||
| export function isTabbableIndex( element ) { | |||
| return getTabIndex( element ) !== -1; | |||
| } | |||
| /** | |||
There was a problem hiding this comment.
Nit: An empty line above maybe
aduth
force-pushed
the
fix/6988-tabbable-radio-by-name
branch
from
2809765
to
2246544
Compare
aduth
force-pushed
the
fix/6988-tabbable-radio-by-name
branch
from
2246544
to
7f9bbda
Compare
This was referenced Mar 18, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 20, 2019
* DOM: Limit single tabbable radio input by name * DOM: Avoid consolidating unnamed radio inputs
youknowriad
pushed a commit
that referenced
this pull request
Mar 20, 2019
* DOM: Limit single tabbable radio input by name * DOM: Avoid consolidating unnamed radio inputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6988
This pull request seeks to enhance the behavior of
tabbables.findto include only a single radio input for a given name, preferring the checked input, falling back to the first in the tabindex-sorted set.Testing Instructions:
Repeat both sets of Steps to Reproduce from #6988 (comment) , verifying the expected behavior.