Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Implement feature flags for Search Block #13829

Closed
wants to merge 12 commits into from
Closed

WIP: Implement feature flags for Search Block #13829

wants to merge 12 commits into from

Commits on Feb 15, 2019

  1. Implement feature flags using webpack's define plugin 

    Add new package for editor configuration, initially containing just feature flags

Rework build commands to use correct NODE_ENV for feature flags

Revert "Rework build commands to use correct NODE_ENV for feature flags"

This reverts commit 4cb0a39.

Revert "Add new package for editor configuration, initially containing just feature flags"

This reverts commit 0c21fc2.

Switch to using webpack define plugin to inject a global GUTENBERG_PHASE variable

Iterate: use window.GUTENBERG_PHASE to avoid thrown errors from an undefined global

Add custom eslint rule for usage of GUTENBERG_PHASE

Disable new eslint rule when used in webpack config

Add readme

Include phase 2 features in e2e tests

Allow use of GUTENBERG_PHASE in a ternary and update documentation.

Add links to docs

Minor docs changes

Switch from window.GUTENBERG_PHASE to process.env.GUTENBERG_PHASE

Update docs for feature flags. Move `Basic Use` section higher up, and simplify a sentence
    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    ffc17e0 View commit details
    Browse the repository at this point in the history

  2. Ensure GUTENBERG_PHASE environment variable is available for webpack

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    2243548 View commit details
    Browse the repository at this point in the history

  3. Ensure GUTENBERG_PHASE is a number

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    1360a25 View commit details
    Browse the repository at this point in the history

  4. Ensure GUTENBERG_PHASE is set in unit tests

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    1476eac View commit details
    Browse the repository at this point in the history

  5. Add feature flags for search block

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    652d711 View commit details
    Browse the repository at this point in the history

  6. Use <rootDir> in jest config

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    7c5280c View commit details
    Browse the repository at this point in the history

  7. switch to using package.json config to define the value of GUTENBERG_… 

    …PHASE
    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    f5bdc39 View commit details
    Browse the repository at this point in the history

  8. Add basic search block e2e test

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    c5c82f9 View commit details
    Browse the repository at this point in the history

  9. Sort custom lint rules alphabetically

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    e818a32 View commit details
    Browse the repository at this point in the history

  10. Add comment about GUTENBERG_PHASE

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    106d82d View commit details
    Browse the repository at this point in the history

  11. Update jest config for GUTENBERG_PHASE

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    f52a902 View commit details
    Browse the repository at this point in the history

  12. Add webpack as dependency to main package.json

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    1e80885 View commit details
    Browse the repository at this point in the history