Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to add a min-width to embeds. #13590

Merged
merged 3 commits into from
Feb 14, 2019
Merged

Try to add a min-width to embeds. #13590

merged 3 commits into from
Feb 14, 2019

Commits on Jan 30, 2019

  1. Try to add a min-width to embeds.

    Embeds are increasingly responsive (as they should be). This branch is very much a "try" branch, in that it simply zeroes out the minimum width of embeds to make the Amazon book embed be responsive. This allows us to create a nice book recommendation grid like this.
    
    However, Amazon themselves include a "Share" modal inside, which is 320px wide and is `opacity: 0;` (until invoked) instead of `display: none;`. So even though the embed itself is smart enough to not even show the Share button when there isn't room, that zero opacity share sheet still causes a horizontal scrollbar, which due to the sandboxing of iframes, we cannot fix.
    
    So this PR is more of a discussion point: what can we do with these embeds? I'm not sure we can do that much. Notably Instagram widgets can't be smaller than 326px, so we can't do this in a blanket way either, or it'll just mess up other embeds.
    
    What are your thoughts?
    Joen Asmussen committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    eb57808 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2019

  1. Configuration menu
    Copy the full SHA
    464d344 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2019

  1. Change to suggested fix.

    jasmussen committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    83d22a2 View commit details
    Browse the repository at this point in the history