[RMmobile] Add Enter.key detection to the Title block #13500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniloercoli
added
the
Mobile App - i.e. Android or iOS
This was referenced Jan 25, 2019
| @@ -42,6 +48,14 @@ class PostTitle extends Component { | |||
| this.props.onUpdate( title ); | |||
| } | |||
|
|
|||
| onEnter( ) { | |||
There was a problem hiding this comment.
We could remove this method entirely and instead copy (and call) this method from the web .js sources.
I've tried it locally and it works and it works.
The advantage of using the same code as the web .js file is that it should make it easier for us to maintain this sourcefile if there are changes, or eventually unify it completely.
| multiline | ||
| numberOfLines={ 0 } | ||
| multiline={ false } | ||
| onSubmitEditing={ this.onEnter } |
There was a problem hiding this comment.
For the comment above to work, this would become onSubmitEditing={ this.props.onEnterPress }
There was a problem hiding this comment.
Nice find @diegoreymendez!
Tested here as well, and worked without problems 👍 I've updated this PR and main PR gb-mobile side.
diegoreymendez
approved these changes
Jan 25, 2019
|
Nice work @daniloercoli ! |
…rnmobile/372-enter-key-detection-to-title * 'master' of https://github.com/WordPress/gutenberg: (29 commits) Update for RangeControl documentation (#12564) Plugin: Deprecate gutenberg_load_list_reusable_blocks (#13456) Update the columns attribute in onSelectImages so that if images are removed via the media modal, the columns can't be higher than the new number of images (#13488) Replace the fullscreen "exit" icon with a back arrow (#13403) Include :visited links in button color (#12183) Amazon Kindle block (#13510) Plugin: Deprecate gutenberg_prepare_blocks_for_js (#13457) Add watcher on Linux: change fs to node-watch (#13448) Plugin: Deprecate `gutenberg` theme support (#13458) Datepicker: Add inValidDay support (#12962) Block Switcher: Render disabled button even if multi-selection (#13431) Plugin: Deprecate gutenberg_register_post_types (#13468) Plugin: Deprecate register_tinymce_scripts (#13466) Set minimum of words for RSS excerpt (#13502) Plugin: Deprecate gutenberg_get_block_categories (#13454) Plugin: Deprecate gutenberg_content_block_version (#13469) API Fetch: Expose nonce on created middleware function (#13451) Plugin: Remove list screens integrations (#13459) Plugin: Remove core-defined block detection functions (#13467) Spec Parser: Move generated spec parser to package (#13493) ...
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Intercept Enter.key and give the ability to add a new block after * Remove the custom mobile code, and use the default web implementation
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Intercept Enter.key and give the ability to add a new block after * Remove the custom mobile code, and use the default web implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Enter.key handling to Title block, and gives the ability to add a new block after it.
This PR set multiline=false, and detect the Enter.key with the default onSubmitEditing prop given by the underlying RN component. It adds a new default empty block after the current. (Default logic on the web).
onSubmitEditing is a very reliable way of detecting Enter.key on TextInput with multiline = false, and works on both HW and SW keyboard without the necessity of implementing hacks with TextWatchers and keyListeners - https://facebook.github.io/react-native/docs/textinput#onsubmitediting
Note: onSubmitEditing does hide the keyboard at the moment, it's a default behavior (at least) on Android. We may need to migrate the Title to RichText if there is no way to circumnavigate this problem.
Note 2: At the moment there is not split in place for the title filed. If you tap enter on the middle of the field there is no split yet.
Previous PR here: #13480