Plugin: Deprecate gutenberg_remove_wpcom_markdown_support #13473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
Gutenberg Plugin
youknowriad
approved these changes
Jan 24, 2019
youknowriad
reviewed
Jan 24, 2019
| if ( class_exists( 'WPCom_Markdown' ) && has_blocks( $post['post_content'] ) ) { | ||
| WPCom_Markdown::get_instance()->unload_markdown_for_posts(); | ||
| } | ||
| _deprecated_function( __FUNCTION__, '5.0.0' ); |
There was a problem hiding this comment.
Not sure what the version refers to here. Should it be the version where we remove it from Gutenberg? 5.1 or 5.2?
There was a problem hiding this comment.
Our use of _deprecated_function would probably be discouraged anyways, but as it's implemented, it's meant to serve to describe the version at which it became deprecated, not when it's to be removed.
$version
(string) (Required) The version of WordPress that deprecated the function.
https://developer.wordpress.org/reference/functions/_deprecated_function/
|
👍 I'm late to the game but looks good. I tested it out on Gutenberg with latest Jetpack and no problems. |
daniloercoli
added a commit
that referenced
this pull request
Jan 24, 2019
…rnmobile/372-add-title-to-gutenberg-mobile * 'master' of https://github.com/WordPress/gutenberg: (56 commits) Save package-lock.json file changes (#13481) Plugin: Deprecate gutenberg_add_responsive_body_class (#13461) Add speak messages to the feature toggle component. (#13385) Plugin: Deprecate gutenberg_kses_allowedtags (#13460) Plugin: Deprecate gutenberg_bulk_post_updated_messages (#13472) Plugin: Avoid calling deprecated gutenberg_silence_rest_errors (#13446) Plugin: Deprecate gutenberg_remove_wpcom_markdown_support (#13473) Fix: Categories block: add custom classes only to wrapper (#13439) is-shallow-equal: Use ES5 ruleset from eslint-plugin module (#13428) Update and Organize Contributors Guide per #12916 (#13352) Dismissible-notices: fix text overlapping icon (X) (#13371) Framework: Remove 5.0-merged REST API integrations (#13408) Plugin: Remove 5.0-merged block registration functions, integrations (#13412) Framework: Bump minimum required WP to 5.x (#13370) [Mobile] Improve keyboard hide button (#13415) Improve castError handling of non strings (#13315) Fix: File block add custom class (#13432) Consider making Fullscreen Mode effects visible only on larger screens (#13425) Update plugin version to 4.9.0 (#13436) DateTimePicker: fix prop warning for (#12933) ...
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #11015
This pull request seeks to deprecate and remove logic from
gutenberg_remove_wpcom_markdown_support. This was a specific plugin compatibility targeting Jetpack. The root issue was fixed in Jetpack as of v6.8.See:
Testing instructions:
Repeat testing instructions from Automattic/jetpack#10635 .
cc @tyxla , @kraftbj, @jeherve