Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: mention dark colour scheme in design docs #13375

Merged
merged 2 commits into from
Jan 22, 2019
Merged

Docs: mention dark colour scheme in design docs #13375

merged 2 commits into from
Jan 22, 2019

Conversation

simison
Copy link
Member

@simison simison commented Jan 19, 2019

Description

Adds a section about dark colour scheme in design docs.

It's easy enough to forget to test with dark backgrounds, just like folks forget to test mobile. Would be great to remind folks to test.

Example what happens when you forget to test: https://github.com/Automattic/wp-calypso/issues/30198

How has this been tested?

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@Soean Soean added the [Type] Developer Documentation Documentation for developers label Jan 20, 2019
@gziolo
Copy link
Member

gziolo commented Jan 22, 2019

I updated the link to reference GitHub directly. Starting the url with the top folder allows us to do that. This will also work on Gutenberg handbook, it is going to be properly updated by set of regular expression applied behind the scenes :)

Saying that, I'm coming to the conclusion that I need to document all those guidelines which emerged when dealing with links.

@gziolo gziolo added this to the Documentation & Handbook milestone Jan 22, 2019
@gziolo
Copy link
Member

gziolo commented Jan 22, 2019

Thanks for this addition, looks good 👍

@gziolo gziolo merged commit bd0f685 into WordPress:master Jan 22, 2019
@simison simison deleted the patch-1 branch January 23, 2019 09:16
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
* Docs: mention dark colour scheme in design docs

* Update link
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
* Docs: mention dark colour scheme in design docs

* Update link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants