Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case for pending to isEditedPostDateFloating suite #13256

Merged
merged 1 commit into from
Jan 10, 2019
Merged

Add test case for pending to isEditedPostDateFloating suite #13256

merged 1 commit into from
Jan 10, 2019

Conversation

davisshaver
Copy link
Contributor

Adds test case covering #13178.

@davisshaver davisshaver mentioned this pull request Jan 9, 2019
Merged
jorgefilipecosta
jorgefilipecosta approved these changes Jan 9, 2019
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test case looks good to me. The test case is currently failing as expected. This PR should only be merged after #13178.

@jorgefilipecosta jorgefilipecosta added this to the 4.9 (Gutenberg) milestone Jan 9, 2019
@jorgefilipecosta jorgefilipecosta added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Status] Blocked Used to indicate that a current effort isn't able to move forward labels Jan 9, 2019
@earnjam earnjam merged commit 85aa580 into WordPress:fix/13176-post-date-pending Jan 10, 2019
@earnjam
Copy link
Contributor

earnjam commented Jan 10, 2019

Whoops, I didn't realize this was a PR against the other PR instead of master. I should have actually merged this one first.

@earnjam earnjam mentioned this pull request Jan 10, 2019
Merged
jorgefilipecosta pushed a commit that referenced this pull request Jan 21, 2019
@davisshaver @jorgefilipecosta
Add test case for pending to isEditedPostDateFloating suite (#13256)
ea7a5a3
jorgefilipecosta pushed a commit that referenced this pull request Jan 21, 2019
@earnjam @jorgefilipecosta
Add test case for pending to isEditedPostDateFloating suite (#13256) (#…
e1e02af 
…13281)

This is just a follow up for #13256. It was opened against the `fix/13176-post-date-pending` branch instead of `master`. It should have been merged there first prior to #13178 getting merged. 

This just brings that test over to `master`.
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@earnjam @youknowriad
Add test case for pending to isEditedPostDateFloating suite (#13256) (#…
bf23e97 
…13281)

This is just a follow up for #13256. It was opened against the `fix/13176-post-date-pending` branch instead of `master`. It should have been merged there first prior to #13178 getting merged. 

This just brings that test over to `master`.
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@earnjam @youknowriad
Add test case for pending to isEditedPostDateFloating suite (#13256) (#…
a4ed183 
…13281)

This is just a follow up for #13256. It was opened against the `fix/13176-post-date-pending` branch instead of `master`. It should have been merged there first prior to #13178 getting merged. 

This just brings that test over to `master`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

Assignees
No one assigned
Labels
[Status] Blocked Used to indicate that a current effort isn't able to move forward [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Milestone
5.0 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
3 participants
@davisshaver @earnjam @jorgefilipecosta