Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require an initial click on embed previews for interactivity #12981

Merged
merged 9 commits into from
Feb 11, 2019
Merged

Require an initial click on embed previews for interactivity #12981

merged 9 commits into from
Feb 11, 2019

Commits on Dec 21, 2018

  1. Require an initial click on embed previews for interactivity 

    This fixes the block selection UX for video embeds. Previously
the click on the video to select the block would start the
video playing. Now that previous require a click to become
interactive, the initial click selects the block without
side effects.
    @notnownikki
    notnownikki committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    1e46e7e View commit details
    Browse the repository at this point in the history

  2. Handle keyboard focus

    @notnownikki
    notnownikki committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    ebd88ee View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2018

  1. Overlay color for demo

    @notnownikki
    notnownikki committed Dec 27, 2018
    Configuration menu
    Copy the full SHA
    4053879 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2019

  1. Merge branch 'master' into update/embed-interactive-content-requires-… 

    …initial-click
    @notnownikki
    notnownikki authored Feb 1, 2019
    Configuration menu
    Copy the full SHA
    6435f68 View commit details
    Browse the repository at this point in the history

  2. Remove dialog role, make overlay transparent

    @notnownikki
    notnownikki committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    bb1336e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'update/embed-interactive-content-requires-initial-click… 

    …' of github.com:WordPress/gutenberg into update/embed-interactive-content-requires-initial-click
    @notnownikki
    notnownikki committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    b2f4481 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2019

  1. Review fixes

    @notnownikki
    notnownikki committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    b37acae View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into update/embed-interactive-content-requires-… 

    …initial-click
    @notnownikki
    notnownikki authored Feb 5, 2019
    Configuration menu
    Copy the full SHA
    391e7ee View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2019

  1. Only update state from props when interactive changes

    @notnownikki
    notnownikki committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    a17ede1 View commit details
    Browse the repository at this point in the history