Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try: Improve permalink editing #12009

Merged
merged 9 commits into from
Mar 18, 2020
Merged

Try: Improve permalink editing #12009

merged 9 commits into from
Mar 18, 2020

Commits on Mar 18, 2020

  1. Filter REST API to return permalink_template

    @earnjam
    earnjam committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    be32226 View commit details
    Browse the repository at this point in the history

  2. Add new getEditedPostSlug selector

    @earnjam
    earnjam committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    d61a01b View commit details
    Browse the repository at this point in the history

  3. Update auto-generated docs

    @earnjam
    earnjam committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    e3b5009 View commit details
    Browse the repository at this point in the history

  4. Make permalink editing more timely/accurate in title editor

    @earnjam
    earnjam committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    d13f4a7 View commit details
    Browse the repository at this point in the history

  5. Make permalink editing more timely/accurate in sidebar panel

    @earnjam
    earnjam committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    ea081f5 View commit details
    Browse the repository at this point in the history

  6. Apply minor code style changes

    @earnjam
    earnjam committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    3217fa1 View commit details
    Browse the repository at this point in the history

  7. Update e2e tests to reflect that panel should always show

    @earnjam
    earnjam committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    bb2f588 View commit details
    Browse the repository at this point in the history

  8. Add unit tests for getEditedPostSlug selector

    @earnjam
    earnjam committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    bd08f74 View commit details
    Browse the repository at this point in the history

  9. Don't show title permalink editor until a save 

    This somewhat diminishes the effects of this pull request, but it will
help it pass the e2e tests and also streamlines writing a bit. Reverts
back to preventing showing the permalink editor in the title until after
a manual or autosave. It does at least show the actual permalink on
the autosave and users can edit the slug at any time using the
document sidebar.
    @earnjam
    earnjam committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    ddeeb8d View commit details
    Browse the repository at this point in the history