Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Enable publishing and saving in production #1166

Merged
merged 3 commits into from
Jun 15, 2017

Conversation

youknowriad
Copy link
Contributor

closes #1036

The new post link is live, we can now enable publishing and saving in production.

@youknowriad youknowriad added the Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts label Jun 14, 2017
@youknowriad youknowriad self-assigned this Jun 14, 2017
@BE-Webdesign
Copy link
Contributor

Couple of things going on with this that I don't think are 100% related to this PR, but I came across while testing.

#1: I didn't notice while testing #1065, but if you edit a post that already exists, using Gutenberg, it will highlight the Gutenberg > New Post submenu.

#2: Our "dirty" checking doesn't seem to update when you change the text of a block until you click outside the block. It would be nice to be able to type some stuff then be able to hit the update button right away.

@aduth
Copy link
Member

aduth commented Jun 14, 2017

Our "dirty" checking doesn't seem to update when you change the text of a block until you click outside the block. It would be nice to be able to type some stuff then be able to hit the update button right away.

It does seem prone to race conditions, but in my testing I was finding that it saves content correctly when following the flow you described?

@BE-Webdesign
Copy link
Contributor

BE-Webdesign commented Jun 14, 2017

It does seem prone to race conditions, but in my testing I was finding that it saves content correctly when following the flow you described?

To clarify, the saving works correctly. I mean that it doesn't seem like you can hit the update button if you type some text and just sit there. Let me make a gif, give me a moment.

@BE-Webdesign
Copy link
Contributor

no-update

@youknowriad
Copy link
Contributor Author

Like discussed with @mtias I updated this to display a confirmation when publishing new posts. We'll drop this confirmation once we have frontend support.

@youknowriad
Copy link
Contributor Author

@BE-Webdesign To clarify the behaviour of the onChange handler of the Editable:

It works like this because it's hard to get TinyMCE work in a controlled way. We limit onChange calls to focusout calls only to avoid some issues we were seeing (focus jumps...), but this doesn't mean we can't try to enable it right now, we had several improvements in how content and focus are updated in the Editable, it could just work right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin: Enable saving and publishing
4 participants