Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RichText: Update registration method signature #11109

Merged
merged 1 commit into from
Oct 26, 2018
Merged

RichText: Update registration method signature #11109

merged 1 commit into from
Oct 26, 2018

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Oct 26, 2018

Description

I missed it when reviewing #10209.

This PR changes the signature of registerFormatType to use name param. This change is introduced only for consistency with registerBlockType and registerPlugin.

There should be no visual changes.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@gziolo gziolo added [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Feature] Extensibility The ability to extend blocks or the editing experience labels Oct 26, 2018
@gziolo gziolo added this to the 4.2 milestone Oct 26, 2018
@gziolo gziolo self-assigned this Oct 26, 2018
@gziolo gziolo requested review from mcsf and ellatrix October 26, 2018 11:58
@ellatrix ellatrix merged commit ac3d50e into master Oct 26, 2018
@ellatrix ellatrix deleted the update/format-api-tweaks branch October 26, 2018 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellatrix ellatrix ellatrix approved these changes

@mcsf mcsf Awaiting requested review from mcsf

Assignees

@gziolo gziolo

Labels
[Feature] Extensibility The ability to extend blocks or the editing experience [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@gziolo @ellatrix