Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement fetchAllMiddleware to handle per_page=-1 through pagination #10762

Merged
merged 21 commits into from
Oct 21, 2018
Merged

Implement fetchAllMiddleware to handle per_page=-1 through pagination #10762

merged 21 commits into from
Oct 21, 2018

Commits on Oct 21, 2018

  1. Implement fetchAllMiddleware to handle per_page=-1 through pagination 

    Introduce a new middleware function to iterate through all available pages
for a large collection, replacing any encountered `per_page=-1` requests
with a series of sequential requests which are assembled into a final
merged array of all available results.
    @kadamwhite @youknowriad
    kadamwhite authored and youknowriad committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    e24f311 View commit details
    Browse the repository at this point in the history

  2. Move fetchAllMiddleware to its own module

    @kadamwhite @youknowriad
    kadamwhite authored and youknowriad committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    a3f3517 View commit details
    Browse the repository at this point in the history

  3. Use @wordpress/url module to modify query strings within fetchAllMidd… 

    …leware
    @kadamwhite @youknowriad
    kadamwhite authored and youknowriad committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    0b13284 View commit details
    Browse the repository at this point in the history

  4. Make fetchAllMiddleware optional within apiFetch and add it with inli… 

    …ne script
    @kadamwhite @youknowriad
    kadamwhite authored and youknowriad committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    c54aa57 View commit details
    Browse the repository at this point in the history

  5. Improve comments for fetchAllMiddleware module

    @kadamwhite @youknowriad
    kadamwhite authored and youknowriad committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    ed69cb5 View commit details
    Browse the repository at this point in the history

  6. Improve fetchAllMiddleware: use links for pagination. 

    - Remove unneeded modification to apiFetch parsing logic.
- Utilize the links header to traverse collection pages.
- Remove confusing try/catch behavior.
- Add more escape hatches for cases where middleware should not apply.
    @kadamwhite @youknowriad
    kadamwhite authored and youknowriad committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    49d80cd View commit details
    Browse the repository at this point in the history

  7. Remove leftover debugging comment

    @kadamwhite @youknowriad
    kadamwhite authored and youknowriad committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    c615efd View commit details
    Browse the repository at this point in the history

  8. Apply fetchAllMiddleware within apiFetch, not client-scripts.php

    @kadamwhite @youknowriad
    kadamwhite authored and youknowriad committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    d122d87 View commit details
    Browse the repository at this point in the history

  9. Simplify obtuse code in query modification logic

    @kadamwhite @youknowriad
    kadamwhite authored and youknowriad committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    e11f34c View commit details
    Browse the repository at this point in the history

  10. Fix improperly reverted parsing code change

    @kadamwhite @youknowriad
    kadamwhite authored and youknowriad committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    7703ce2 View commit details
    Browse the repository at this point in the history

  11. Fix unit tests

    @youknowriad
    youknowriad committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    c2c2f6c View commit details
    Browse the repository at this point in the history

  12. Avoid circular dependency

    @youknowriad
    youknowriad committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    158f088 View commit details
    Browse the repository at this point in the history

  13. Adding some unit tests

    @youknowriad
    youknowriad committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    5c7a2f2 View commit details
    Browse the repository at this point in the history

  14. Remove useless per_page argument

    @youknowriad
    youknowriad committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    b7bb2cd View commit details
    Browse the repository at this point in the history

  15. Update the lock file

    @youknowriad
    youknowriad committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    5436e18 View commit details
    Browse the repository at this point in the history

  16. Update api-fetch CHANGELOG

    @youknowriad
    youknowriad committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    8803b88 View commit details
    Browse the repository at this point in the history

  17. Fetch as many attachments as we can, even if its not all of them

    @danielbachhuber
    danielbachhuber committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    0a08388 View commit details
    Browse the repository at this point in the history

  18. Remove per_page=-1 support shim in REST API

    @danielbachhuber
    danielbachhuber committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    1ce1f2b View commit details
    Browse the repository at this point in the history

  19. Ensure the next page of results is actually fetched

    @danielbachhuber
    danielbachhuber committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    93eeecc View commit details
    Browse the repository at this point in the history

  20. Tweak the middleware chain to avoid mutations

    @youknowriad
    youknowriad committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    08e8ca8 View commit details
    Browse the repository at this point in the history

  21. Testing fetching consequential pages

    @youknowriad
    youknowriad committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    562250d View commit details
    Browse the repository at this point in the history