Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover image: Hide Settings if no image is selected. #4433

Closed
Soean opened this issue Jan 12, 2018 · 1 comment · Fixed by #6498
Closed

Cover image: Hide Settings if no image is selected. #4433

Soean opened this issue Jan 12, 2018 · 1 comment · Fixed by #6498
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Milestone
Merge: Editor

Comments

@Soean
Copy link
Member

Soean commented Jan 12, 2018 •
edited
Loading

Issue Overview

The Cover image settings of the Cover image block should be hidden, if no image is selected, like in the image, gallery, audio and video block.

Screenshots / Video

cover-image-settings
@Soean Soean added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks labels Jan 12, 2018
joaodfmota pushed a commit to joaodfmota/gutenberg that referenced this issue Jan 12, 2018
Fix WordPress#4433
b60a84f
@joaodfmota joaodfmota mentioned this issue Jan 12, 2018
Closed
3 tasks
joaodfmota pushed a commit to joaodfmota/gutenberg that referenced this issue Jan 12, 2018
InspectorControls WordPress#4433
5f15ed1
@karmatosed karmatosed added this to the Merge Proposal milestone Jan 25, 2018
@jeffpaul
Copy link
Member

This ticket was mentioned in Slack in #core-editor by jeffpaul. View the logs.

@youknowriad youknowriad mentioned this issue Apr 30, 2018
Merged
dmsnell added a commit that referenced this issue May 4, 2023
@dmsnell
HTML API: Backport updates from Core
23c6c1a 
In this "blessed" patch we're backporting some udpates coming from Core in the
Tag Processor, namely a major fix to a rare bug that occurs when making changes
and then seeking to an earlier position in a document.

 - Preserve internal cursor across updates [#4371](WordPress/wordpress-develop#4371)
 - Update code example formatting to fix Developer Resources docs [#4419](WordPress/wordpress-develop#4419)
 - Update whitespace formatting to pass Gutenberg linter [#4433](WordPress/wordpress-develop#4422)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Merge: Editor
Development

Successfully merging a pull request may close this issue.

Cover Image: Hide inspector controls if no image is selected WordPress/gutenberg
3 participants
@karmatosed @Soean @jeffpaul