Change the navigation menu add block button tooltip

[theminaldiwan]

What problem does this address?

While using navigation block and when we adding new menu on that we facing problem adding menu from where because menu add block button tooltip is same as other block button.

What is your proposed solution?

Need to changing add block button for navigation block menu item and 'Add block' button tooltip name to 'Add Menu Item'.
screenshot:

[paaljoachim]

@getdave here is a Navigation block issue to take a closer look at.

[getdave]

@theminaldiwan thank you for taking the time to raise this Issue. It's been added to the tracking issue for the block.

[theminaldiwan]

Thanks @getdave and @paaljoachim for you response.

[github-actions]

Hi,
This issue has gone 180 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

[Thelmachido]

Hi @getdave it looks like this is on the to-do list.

Just checking if there's still a plan to move this forward.

[getdave]

Seems simple enough. Low hanging fruit. Possible good first issue.

[koneweczka]

@getdave Can I take it? I think I can do this one :)

[getdave]

@getdave Can I take it? I think I can do this one :)

Please do 🙇

[koneweczka]

Ok, so I forked it and here I go :) Can you assign this issue to me?

[koneweczka]

So - after first look at it -I already find the right place, but have some thoughts. This navigation menu use this ButtonBlockAppender as "inner block" button. This ButtonBlockAppender is also used in e.g. adding columns. If I change this block label to "Add menu item" it also impacts e.g. columns item (or other blocks, I just checked few of them) - here's the screen.

So - right now the simplest solution can be just changing it to "Add new item" (Or maybe"Add block item"?) to differ it from "Add block". I already changed it in this commit.

BUT - I was wondering: maybe we can think about including the block name and this can looks like this "Add ${blockName} item" e.g. "Add column item", "Add nav menu item". I was trying to do this right now, but inserted value have some problem with methods for translation and converting strings, but I can try to check it again and do some more research.

What do you think? Is this small change enough? Or maybe we (I :D) can do more?