Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Site Title Block #30918

Closed
8 of 13 tasks
priethor opened this issue Apr 16, 2021 · 7 comments
Closed
8 of 13 tasks

Improvements to Site Title Block #30918

priethor opened this issue Apr 16, 2021 · 7 comments
Labels
[Block] Site Title Affects the Site Title Block [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@priethor
Copy link
Contributor

priethor commented Apr 16, 2021

High Priority (target WP 5.8)

Low Priority

@priethor priethor added [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. [Block] Site Title Affects the Site Title Block labels Apr 16, 2021
@mtias
Copy link
Member

mtias commented Apr 19, 2021

Full feature parity with Heading Block, with fine-grained styling options that require rich text

I don't think this can be achieved without some significant changes that could be considered breaking ones for the site title.

@kjellr
Copy link
Contributor

kjellr commented May 4, 2021

The Site Title block is also missing Bold and Italic options. These seem expected, considering the block's similarity to the Heading block. Would it be possible to add these to the list?

Site Title Block Heading Block
Screen Shot 2021-05-04 at 11 36 14 AM Screen Shot 2021-05-04 at 11 37 12 AM

@priethor
Copy link
Contributor Author

priethor commented May 4, 2021

Thanks, added them to the list.

However, the site title is expected to be plain text, whereas enabling core/bold and core/italic styles in the Site Title block's RichText generates HTML markup, which would require significant changes as commented above or seen recently with the Post Title block. A solution for this would be to enable Bold and Italic formatting as block attributes applying to the whole title.

Would that make sense in the context of the patterns you are working on, @kjellr ?

@kjellr
Copy link
Contributor

kjellr commented May 4, 2021

Yeah, that makes sense technically. Adding them as block attributes to start with might be fine, but I do think it would be worth figuring out a way around that eventually. From a user's perspective, they just want the title to be bold — and they'll be looking for those controls in the same place they look for them for other blocks.

@carolinan
Copy link
Contributor

carolinan commented May 12, 2021

Margin has been added with #31728

@youknowriad
Copy link
Contributor

Let's continue improving the blocks but I'm removing this from the 5.8 board as we're passed the feature freeze date. Bug fixes can continue to land though and important iterations (case by case) can be considered.

@priethor
Copy link
Contributor Author

Let's close this issue as most of the high-priority items are already covered and this is not a focus anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Title Affects the Site Title Block [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
None yet
Development

No branches or pull requests

5 participants