Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider fine-tuning the hover/select animation for blocks #15156

Closed
kjellr opened this issue Apr 24, 2019 · 4 comments
Closed

Consider fine-tuning the hover/select animation for blocks #15156

kjellr opened this issue Apr 24, 2019 · 4 comments
Assignees
Labels
Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@kjellr
Copy link
Contributor

kjellr commented Apr 24, 2019

Related to #8029.

When building in the updated block borders in #14145, there was some discussion around trying our alternative animations (I can't find it in the thread, but I remember it happening somewhere! 😬)

I'm opening this ticket to track some ideas. Please remember: it's quite possible we will not decide to pursue any of these. For a common action like hovering/selecting a block, we want to be the animation to be as natural (and probably as minimal) as possible. It's also worth keeping in mind that if #14961 lands, it'll likely bring some animation too, so we don't want to overdo it.

It's also worth noting that anything we build in here should adhere to our animation guidelines, and will be off automatically for users with the "prefers reduced motion" preference set in their OS.

Some early explorations:

NOTE: All these GIFs have been slowed down to catch the quick effects. Click through to the demos to check out real-time animations.


Expand from left

animation-01

Demo: https://codepen.io/kjellr/full/BEGBoO


Growing Selection Border

animation-02

Demo: https://codepen.io/kjellr/full/BEqgvQ


Growing Hover Border

animation-03

Demo: https://codepen.io/kjellr/full/eoPavJ

@kjellr kjellr added [Type] Enhancement A suggestion for improvement. Needs Design Needs design efforts. labels Apr 24, 2019
@kjellr kjellr self-assigned this Apr 24, 2019
@kjellr kjellr added the Needs Design Feedback Needs general design feedback. label Apr 24, 2019
@davewhitley
Copy link
Contributor

davewhitley commented Apr 25, 2019

Expand from left

This is lovely, although I didn't like it until I tried it in Safari. In Chrome, The left border expands unnaturally — let me know if you can reproduce.

The animation is subtle, and I love how the border disappears when you unfocus. That's my favorite part about it. It'll be interesting to see how the slide from left animation works with a block toolbar that is much longer.

Growing Selection Border

My least favorite because the animations seem very long and distracting. Hard to keep track of the toolbar with my eyes.

Growing Hover Border

This is probably my favorite. The animation is nice and subtle. The only thing I don't like is how the toolbar seems to "blink" when you start clicking on blocks at a quick pace (as a result of the opacity change). The expand from left demo didn't have this problem. On the other hand, the left border on the expand from left demo seems more "blinky" than this one, and the one here is much more soothing to me.

You might consider not animating the toolbar at all since that is a high-use piece of UI.

@kjellr
Copy link
Contributor Author

kjellr commented Apr 25, 2019

This is lovely, although I didn't like it until I tried it in Safari. In Chrome, The left border expands unnaturally — let me know if you can reproduce.

Good catch! I missed that somehow. The animation was mistakenly adding a left border before it animated everything. 😄 Should be fixed now.

Growing Hover Border

This is probably my favorite. The animation is nice and subtle. The only thing I don't like is how the toolbar seems to "blink" when you start clicking on blocks at a quick pace (as a result of the opacity change). The expand from left demo didn't have this problem. On the other hand, the left border on the expand from left demo seems more "blinky" than this one, and the one here is much more soothing to me.

Here's a slightly different version — I've slowed down the animation just a bit and added a longer fade-in for the left border. In this case, users may actually end up clicking before the animation is complete, but if they do it still looks fine, so I don't think it's a problem. Let me know what you think:

https://codepen.io/kjellr/full/ROEWym

You might consider not animating the toolbar at all since that is a high-use piece of UI.

Yeah, definitely. A super-quick fade may be fine, but I'm a little nervous about doing a scale animation there (like on the first and second animations). They may end up being too distracting.

@mapk
Copy link
Contributor

mapk commented Jul 16, 2019

Nice concepts of animation! I tend to agree with @drw158 that Growing from Hover is the one I like most. Initially, I felt when hovering rapidly through several blocks, the animation was a lot, but now it's really not that much in relation to the default hover appearance.

hover

@mapk
Copy link
Contributor

mapk commented Jan 21, 2020

With G2 UI design work on the way (#18667), I think we can close this one.

@mapk mapk closed this as completed Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants