Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve shortcuts for common formatting commands #14031

Open
afercia opened this issue Feb 21, 2019 · 6 comments
Open

Improve shortcuts for common formatting commands #14031

afercia opened this issue Feb 21, 2019 · 6 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Decision Needs a decision to be actionable or relevant [Type] Enhancement A suggestion for improvement.

Comments

@afercia
Copy link
Contributor

afercia commented Feb 21, 2019

Splitting this out from #13034

I'd recommend to review the keyboard shortcuts for the most common formatting. Some of these shortcuts use only one modifier key and conflict with native browsers shortcuts, preventing access to browsers features. For example, primary + u prevents from viewing Page Source in Firefox and it's very likely there are other conflicts, as the browsers native shortcuts vary across operating systems and, sometimes, their locale settings.

Also, they're inconsistent with each other and very difficult to remember, for example:

- primary + b (bold)
- primary + i (italic)
- access  + x (code)
- access  + d (strikethrough) 
- primary + u (underline)

Image and Link are special cases, but I'd consider to make the formatting ones above use the same modifiers. Please let me know if I should create a new issue.
@afercia afercia added the [Type] Enhancement A suggestion for improvement. label Feb 21, 2019
@afercia afercia mentioned this issue Feb 21, 2019
Closed
@ellatrix
Copy link
Member

I'm not sure what to do here. Do you have any suggestions? primary + b/i we can never change. primary + anything else may result in conflicts. So they can never be consistent?

@ellatrix
Copy link
Member

ellatrix commented Mar 1, 2019

Just noticed that Google Docs also has different modifiers for strikethrough (cmd+shift).

@afercia
Copy link
Contributor Author

afercia commented Mar 1, 2019

Worth noting Google docs uses <body role="application" ... which does many things with assistive technologies, including instructing screen readers to stop intercepting keystrokes for their own usage. It's a completely different model so we can't expect keyboard shortcuts used in Google Docs will work with screen readers.

@ellatrix
Copy link
Member

ellatrix commented Mar 1, 2019

Not sure how that's relevant here. This issue is that the shortcuts are different. We can't make them the same? What's actionable here?

@afercia
Copy link
Contributor Author

afercia commented Mar 1, 2019

I'm just advising to not use Google Docs as an example 🙂 what works there may not work in G.

@ellatrix
Copy link
Member

@afercia What should we do here? Should we drop the shortcuts for code and strikethrough?

@arunsathiya arunsathiya mentioned this issue Apr 5, 2019
Closed
@mtias mtias added the Needs Decision Needs a decision to be actionable or relevant label Aug 30, 2020
@cuemarie cuemarie mentioned this issue Apr 12, 2023
Closed
@priethor priethor added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed [a11y] Keyboard & Focus labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Decision Needs a decision to be actionable or relevant [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mtias @afercia @ellatrix @priethor