Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underlining text using the keyboard shortcut does not work consistently in major browsers #13034

Closed
anmol257 opened this issue Dec 20, 2018 · 12 comments
Assignees
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@anmol257
Copy link

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

@anmol257
Copy link
Author

There is no option to underline text including heading. Clt + u opens source. So In order to underline every time I have to use HTML coding. Kindly provide a button for it within Gutenberg in order to improve convenience.

@swissspidy swissspidy added the [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable label Dec 20, 2018
@swissspidy
Copy link
Member

Previously: #7162, #12814, #10728.


In Chrome on macOS Ctrl + U works fine, bot in Firefox it does nothing.

@afercia afercia added the [Type] Bug An existing feature does not function as intended label Dec 26, 2018
@afercia
Copy link
Contributor

afercia commented Dec 26, 2018

On macOS the dedicated shortcut is Cmd + U, as listed in the Keyboard Shortcuts modal:

screenshot 2018-12-26 at 17 03 19

However, in Chrome it doesn't do anything, in Firefox it opens the view source. In the Classic Editor, it works. I'd call this a bug.

@jorgefilipecosta jorgefilipecosta self-assigned this Dec 27, 2018
@designsimply designsimply added the Browser Issues Issues or PRs that are related to browser specific problems label Jan 8, 2019
@designsimply designsimply changed the title Underlining text in firefox browser Underlining text using the keyboard shortcut does not work consistently in major browsers Jan 9, 2019
@talldan talldan added the [Type] Regression Related to a regression in the latest release label Jan 11, 2019
@talldan
Copy link
Contributor

talldan commented Jan 11, 2019

It seems like it must be a regression since it's been audited in the past as working:
#71 (comment)

@ellatrix
Copy link
Member

This no longer works since #12249 and is now not included in Gutenberg 5.1.

@ellatrix ellatrix reopened this Feb 21, 2019
@afercia
Copy link
Contributor

afercia commented Feb 21, 2019

Underline has just been restored in #14008

However, I'd recommend to review the keyboard shortcuts for the most common formatting. Some of these shortcuts use only one modifier key and still conflict with native browsers shortcuts, preventing access to browsers features.

Also, they're inconsistent with each other and very difficult to remember, for example:

- primary + b (bold)
- primary + i (italic)
- access  + x (code)
- access  + d (strikethrough) 
- primary + u (underline)

Image and Link are special cases, but I'd consider to make the formatting ones above use the same modifiers. Please let me know if I should create a new issue.

@ellatrix
Copy link
Member

@afercia Yes, please create a new issue. Also with detailed information about which formatting shortcuts are conflicting with the OS/browser.

@afercia
Copy link
Contributor

afercia commented Feb 21, 2019

with detailed information about which formatting shortcuts are conflicting with the OS/browser.

I'm afraid that would be a bit too much for me :) no bandwidth to test all supported browsers in at least the 3 major desktop operating systems.

@afercia
Copy link
Contributor

afercia commented Feb 21, 2019

Created #14031. I guess this one can be closed now? Please do feel free to reopen if I'm missing something.

@afercia afercia closed this as completed Feb 21, 2019
@drewclifton
Copy link

Underline via cmd+u not working for me today on 5.1.1 (Chrome)

@iamkingsleyf
Copy link

still not working

@supernovia
Copy link

Just noting this isn't working in Chrome current on Mac current with command + U.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

No branches or pull requests

10 participants