Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WordPress 5.0.3 started inserting unwanted <p> #13345

Closed
manake opened this issue Jan 16, 2019 · 2 comments
Closed

WordPress 5.0.3 started inserting unwanted <p> #13345

manake opened this issue Jan 16, 2019 · 2 comments
Labels
[Feature] Block API API that allows to express the block paradigm. Needs Technical Feedback Needs testing from a developer perspective. [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.

Comments

@manake
Copy link

manake commented Jan 16, 2019 •
edited
Loading

(Post removed. Fixed.)
@spencerfinnell
Copy link

spencerfinnell commented Jan 16, 2019 •
edited
Loading

For a while actually:

#9056
#9528
#12530
#12668

It's very easy to reproduce and currently makes dynamic blocks annoying to develop: https://gist.github.com/spencerfinnell/df70436ec9a711ca9e9d00f1492e2c91

This does not happen for core blocks because they generate a single string of HTML markup: https://github.com/WordPress/gutenberg/blob/master/packages/block-library/src/latest-posts/index.php#L29

However this is not a realistic solution for more complex blocks where other partials/views are likely to be loaded in.

@swissspidy swissspidy added Needs Technical Feedback Needs testing from a developer perspective. [Feature] Block API API that allows to express the block paradigm. [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes. labels Jan 22, 2019
aldavigdis pushed a commit to Automattic/jetpack that referenced this issue Feb 8, 2019
Adding remove_filter statement to get around a known bug in WP Core
368d973 
Extra p and br tags are being added to server-side generated blocks. This seems to be related to the do_blocks function in wp-includes/blocks.php adding and removing filters too early.

Related: WordPress/gutenberg#13345, https://core.trac.wordpress.org/ticket/45495 and more
aldavigdis pushed a commit to Automattic/jetpack that referenced this issue Feb 12, 2019
Adding remove_filter statement to get around a known bug in WP Core
a49d60f 
Extra p and br tags are being added to server-side generated blocks. This seems to be related to the do_blocks function in wp-includes/blocks.php adding and removing filters too early.

Related: WordPress/gutenberg#13345, https://core.trac.wordpress.org/ticket/45495 and more
@youknowriad
Copy link
Contributor

This is a duplicate of #12530 and the core ticket seems fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Block API API that allows to express the block paradigm. Needs Technical Feedback Needs testing from a developer perspective. [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@youknowriad @spencerfinnell @swissspidy @manake