Selection.getRangeAt(). getRangeAt() issue on Safari

[phpbits]

@youknowriad I'm suddenly getting error on safari regarding const range = getSelection().getRangeAt( 0 ); . It says:

IndexSizeError: DOM Exception 1: Index or size was negative, or greater than the allowed value.

Seems like safari doesn't fully support it yet : https://developer.mozilla.org/en-US/docs/Web/API/Selection/getRangeAt .

Thanks!

-- copied from my comment here : #4872 . Thanks!

[ocean90]

Thanks for the report! Which script is producing the error? I'm asking because #4872 did not add a getSelection().getRangeAt( 0 ) line. Unlike this and this, the one mentioned in the pull request was checking for selection.rangeCount first. But that line actually doesn't exist anymore.

Other examples checking for rangeCount first:

• gutenberg/packages/dom/src/dom.js

  Line 165 in c05ede7

  const range = selection.rangeCount ? selection.getRangeAt( 0 ) : null;

• gutenberg/packages/format-library/src/link/positioned-at-selection.js

  Line 18 in d95c7d6

  // as to avoid a thrown error by `Selection#getRangeAt` on invalid index.

[phpbits]

@ocean90 how about adding the condition on all getSelection().getRangeAt( 0 )? Hoping this const range = selection.rangeCount ? selection.getRangeAt( 0 ) : null; should be added on both files that you've mentioned. Let me know your thoughts. Thanks!

[johngodley]

Is this fixed in #11209?

[phpbits]

@johngodley Thanks! That's the fixes I've added too and it's working fine :) Hoping it'll got merge soon. Thanks again!

[aduth]

Closing per confirmation at #11457 (comment) .

Noting there were similar recent issues in Safari, also fixed in #15576 (expected for Gutenberg 5.7 / WordPress 5.2.1).