Skip to content

Commit

Permalink
Icon: Remove knobs in stories (#46517)
Browse files Browse the repository at this point in the history
  • Loading branch information
mirka authored Dec 21, 2022
1 parent 3922379 commit 921135f
Show file tree
Hide file tree
Showing 2 changed files with 103 additions and 128 deletions.
128 changes: 0 additions & 128 deletions packages/components/src/icon/stories/index.js

This file was deleted.

103 changes: 103 additions & 0 deletions packages/components/src/icon/stories/index.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
/**
* External dependencies
*/
import type { ComponentMeta, ComponentStory } from '@storybook/react';

/**
* WordPress dependencies
*/
import { SVG, Path } from '@wordpress/primitives';
import { wordpress } from '@wordpress/icons';

/**
* Internal dependencies
*/
import Icon from '..';
import { VStack } from '../../v-stack';

const meta: ComponentMeta< typeof Icon > = {
title: 'Components/Icon',
component: Icon,
parameters: {
controls: { expanded: true },
docs: { source: { state: 'open' } },
},
};
export default meta;

const Template: ComponentStory< typeof Icon > = ( args ) => (
<Icon { ...args } />
);

export const Default = Template.bind( {} );
Default.args = {
icon: wordpress,
};

export const FillColor: ComponentStory< typeof Icon > = ( args ) => {
return (
<div
style={ {
fill: 'blue',
} }
>
<Icon { ...args } />
</div>
);
};
FillColor.args = {
...Default.args,
};

export const WithAFunction = Template.bind( {} );
WithAFunction.args = {
...Default.args,
icon: () => (
<SVG>
<Path d="M5 4v3h5.5v12h3V7H19V4z" />
</SVG>
),
};

const MyIconComponent = () => (
<SVG>
<Path d="M5 4v3h5.5v12h3V7H19V4z" />
</SVG>
);

export const WithAComponent = Template.bind( {} );
WithAComponent.args = {
...Default.args,
icon: MyIconComponent,
};

export const WithAnSVG = Template.bind( {} );
WithAnSVG.args = {
...Default.args,
icon: (
<SVG>
<Path d="M5 4v3h5.5v12h3V7H19V4z" />
</SVG>
),
};

/**
* Although it's preferred to use icons from the `@wordpress/icons` package, Dashicons are still supported,
* as long as you are in a context where the Dashicons stylesheet is loaded. To simulate that here,
* use the Global CSS Injector in the Storybook toolbar at the top and select the "WordPress" preset.
*/
export const WithADashicon: ComponentStory< typeof Icon > = ( args ) => {
return (
<VStack>
<Icon { ...args } />
<small>
This won’t show an icon if the Dashicons stylesheet isn’t
loaded.
</small>
</VStack>
);
};
WithADashicon.args = {
...Default.args,
icon: 'wordpress',
};

1 comment on commit 921135f

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flaky tests detected.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3751947277
📝 Reported issues:

Please sign in to comment.