Don't use index for React element keys

WordPress · Oct 26, 2018 · 7fd020f · 7fd020f
1 parent 35d017d
commit 7fd020f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/editor/src/components/rich-text/format-edit.js b/packages/editor/src/components/rich-text/format-edit.js
@@ -69,7 +69,7 @@ class Shortcut extends Component {
 const FormatEdit = ( { onChange, value } ) => {
 	return (
 		<Fragment>
-			{ getFormatTypes().map( ( { name, edit: Edit, keywords }, i ) => {
+			{ getFormatTypes().map( ( { name, edit: Edit, keywords } ) => {
 				if ( ! Edit ) {
 					return null;
 				}
@@ -80,7 +80,7 @@ const FormatEdit = ( { onChange, value } ) => {
 
 				return (
 					<Edit
-						key={ i }
+						key={ name }
 						isActive={ isActive }
 						activeAttributes={ activeAttributes }
 						value={ value }

diff --git a/packages/editor/src/components/rich-text/format-toolbar/index.js b/packages/editor/src/components/rich-text/format-toolbar/index.js
@@ -8,8 +8,8 @@ const FormatToolbar = ( { controls } ) => {
 	return (
 		<div className="editor-format-toolbar">
 			<Toolbar>
-				{ controls.map( ( format, index ) =>
-					<Slot name={ `RichText.ToolbarControls.${ format }` } key={ index } />
+				{ controls.map( ( format ) =>
+					<Slot name={ `RichText.ToolbarControls.${ format }` } key={ format } />
 				) }
 			</Toolbar>
 		</div>