Add missing field _invalid in menu item REST API (#34670)

* Add missing field * Lint * Feedback. * Fix tests. * Fix lint
WordPress · Sep 14, 2021 · 4aaf626 · 4aaf626
1 parent 8714f66
commit 4aaf626
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/class-wp-rest-menu-items-controller.php b/lib/class-wp-rest-menu-items-controller.php
@@ -695,6 +695,10 @@ public function prepare_item_for_response( $post, $request ) {
 			$data['xfn'] = array_map( 'sanitize_html_class', explode( ' ', $menu_item->xfn ) );
 		}
 
+		if ( rest_is_field_included( 'invalid', $fields ) ) {
+			$data['invalid'] = (bool) $menu_item->_invalid;
+		}
+
 		if ( rest_is_field_included( 'meta', $fields ) ) {
 			$data['meta'] = $this->meta->get_value( $menu_item->ID, $request );
 		}
@@ -1007,7 +1011,7 @@ public function get_item_schema() {
 			),
 		);
 
-		$schema['properties']['_invalid'] = array(
+		$schema['properties']['invalid'] = array(
 			'description' => __( 'Whether the menu item represents an object that no longer exists.', 'gutenberg' ),
 			'context'     => array( 'view', 'edit', 'embed' ),
 			'type'        => 'boolean',

diff --git a/phpunit/class-rest-nav-menu-items-controller-test.php b/phpunit/class-rest-nav-menu-items-controller-test.php
@@ -654,7 +654,7 @@ public function test_get_item_schema() {
 		$this->assertArrayHasKey( 'title', $properties );
 		$this->assertArrayHasKey( 'type', $properties );
 		$this->assertArrayHasKey( 'xfn', $properties );
-		$this->assertArrayHasKey( '_invalid', $properties );
+		$this->assertArrayHasKey( 'invalid', $properties );
 	}
 
 	/**
@@ -792,6 +792,8 @@ protected function check_menu_item_data( $post, $data, $context, $links ) {
 			$this->assertEmpty( $data['parent'] );
 		}
 
+		$this->assertFalse( $data['invalid'] );
+
 		// page attributes.
 		$this->assertEquals( $post->menu_order, $data['menu_order'] );