Skip to content

Commit

Permalink
alt+f10 only works on edit mode
Browse files Browse the repository at this point in the history
  • Loading branch information
@youknowriad
youknowriad committed Jul 11, 2019
1 parent b065c70 commit 465a2a9
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 224 deletions.
1 change: 1 addition & 0 deletions packages/block-editor/src/components/block-list/block.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -544,6 +544,7 @@ function BlockListBlock( {
/>
) }
{
isKeyboardEditMode &&
! shouldShowContextualToolbar &&
isSelected &&
! hasFixedToolbar &&
Expand Down
224 changes: 0 additions & 224 deletions packages/e2e-tests/specs/__snapshots__/writing-flow.test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -223,227 +223,3 @@ exports[`Writing Flow should remember initial vertical position 1`] = `
<p><br>2</p>
<!-- /wp:paragraph -->"
`;
exports[`adding blocks Should navigate inner blocks with arrow keys 1`] = `
"<!-- wp:paragraph -->
<p>First paragraph</p>
<!-- /wp:paragraph -->
<!-- wp:columns -->
<div class=\\"wp-block-columns\\"><!-- wp:column -->
<div class=\\"wp-block-column\\"><!-- wp:paragraph -->
<p>First col</p>
<!-- /wp:paragraph --></div>
<!-- /wp:column -->
<!-- wp:column -->
<div class=\\"wp-block-column\\"><!-- wp:paragraph -->
<p>Second col</p>
<!-- /wp:paragraph --></div>
<!-- /wp:column --></div>
<!-- /wp:columns -->
<!-- wp:paragraph -->
<p>Second paragraph</p>
<!-- /wp:paragraph -->"
`;
exports[`adding blocks should create valid paragraph blocks when rapidly pressing Enter 1`] = `
"<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->
<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->
<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->
<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->
<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->
<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->
<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->
<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->
<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->
<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->
<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->"
`;
exports[`adding blocks should insert line break at end 1`] = `
"<!-- wp:paragraph -->
<p>a<br></p>
<!-- /wp:paragraph -->"
`;
exports[`adding blocks should insert line break at end and continue writing 1`] = `
"<!-- wp:paragraph -->
<p>a<br>b</p>
<!-- /wp:paragraph -->"
`;
exports[`adding blocks should insert line break at start 1`] = `
"<!-- wp:paragraph -->
<p><br>a</p>
<!-- /wp:paragraph -->"
`;
exports[`adding blocks should insert line break in empty container 1`] = `
"<!-- wp:paragraph -->
<p><br></p>
<!-- /wp:paragraph -->"
`;
exports[`adding blocks should insert line break mid text 1`] = `
"<!-- wp:paragraph -->
<p>a<br>b</p>
<!-- /wp:paragraph -->"
`;
exports[`adding blocks should merge forwards 1`] = `
"<!-- wp:paragraph -->
<p>123</p>
<!-- /wp:paragraph -->"
`;
exports[`adding blocks should navigate around inline boundaries 1`] = `
"<!-- wp:paragraph -->
<p>FirstAfter</p>
<!-- /wp:paragraph -->
<!-- wp:paragraph -->
<p>Before<strong>InsideSecondInside</strong>After</p>
<!-- /wp:paragraph -->
<!-- wp:paragraph -->
<p>BeforeThird</p>
<!-- /wp:paragraph -->"
`;
exports[`adding blocks should navigate around nested inline boundaries 1`] = `
"<!-- wp:paragraph -->
<p><strong><em>1</em> <em>2</em></strong></p>
<!-- /wp:paragraph -->"
`;
exports[`adding blocks should navigate around nested inline boundaries 2`] = `
"<!-- wp:paragraph -->
<p>a<strong>b<em>c1d</em>e f<em>g2h</em>i</strong>j</p>
<!-- /wp:paragraph -->"
`;
exports[`adding blocks should navigate contenteditable with padding 1`] = `
"<!-- wp:paragraph -->
<p>1</p>
<!-- /wp:paragraph -->
<!-- wp:paragraph -->
<p>2</p>
<!-- /wp:paragraph -->"
`;
exports[`adding blocks should navigate empty paragraph 1`] = `
"<!-- wp:paragraph -->
<p>1</p>
<!-- /wp:paragraph -->
<!-- wp:paragraph -->
<p>2</p>
<!-- /wp:paragraph -->"
`;
exports[`adding blocks should not create extra line breaks in multiline value 1`] = `
"<!-- wp:quote -->
<blockquote class=\\"wp-block-quote\\"><p></p></blockquote>
<!-- /wp:quote -->"
`;
exports[`adding blocks should not delete surrounding space when deleting a selected word 1`] = `
"<!-- wp:paragraph -->
<p>alpha gamma</p>
<!-- /wp:paragraph -->"
`;
exports[`adding blocks should not delete surrounding space when deleting a selected word 2`] = `
"<!-- wp:paragraph -->
<p>alpha beta gamma</p>
<!-- /wp:paragraph -->"
`;
exports[`adding blocks should not delete surrounding space when deleting a word with Alt+Backspace 1`] = `
"<!-- wp:paragraph -->
<p>alpha gamma</p>
<!-- /wp:paragraph -->"
`;
exports[`adding blocks should not delete surrounding space when deleting a word with Alt+Backspace 2`] = `
"<!-- wp:paragraph -->
<p>alpha beta gamma</p>
<!-- /wp:paragraph -->"
`;
exports[`adding blocks should not delete surrounding space when deleting a word with Backspace 1`] = `
"<!-- wp:paragraph -->
<p>1 3</p>
<!-- /wp:paragraph -->"
`;
exports[`adding blocks should not delete surrounding space when deleting a word with Backspace 2`] = `
"<!-- wp:paragraph -->
<p>1 2 3</p>
<!-- /wp:paragraph -->"
`;
exports[`adding blocks should not prematurely multi-select 1`] = `
"<!-- wp:paragraph -->
<p>1</p>
<!-- /wp:paragraph -->
<!-- wp:paragraph -->
<p>></p>
<!-- /wp:paragraph -->"
`;
exports[`adding blocks should preserve horizontal position when navigating vertically between blocks 1`] = `
"<!-- wp:paragraph -->
<p>abc</p>
<!-- /wp:paragraph -->
<!-- wp:paragraph -->
<p>123</p>
<!-- /wp:paragraph -->"
`;
exports[`adding blocks should remember initial vertical position 1`] = `
"<!-- wp:paragraph -->
<p>1x</p>
<!-- /wp:paragraph -->
<!-- wp:paragraph -->
<p><br>2</p>
<!-- /wp:paragraph -->"
`;
1 change: 1 addition & 0 deletions packages/e2e-tests/specs/embedding.test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,7 @@ describe( 'Embedding content', () => {

// Start a new post, embed the previous post.
await createNewPost();
await switchToEditMode();
await clickBlockAppender();
await page.keyboard.type( '/embed' );
await page.keyboard.press( 'Enter' );
Expand Down

0 comments on commit 465a2a9

Please sign in to comment.