Skip to content

Improve code commenting around focus mount behaviour of rich text Link UI #82346

Improve code commenting around focus mount behaviour of rich text Link UI

Improve code commenting around focus mount behaviour of rich text Link UI #82346

Triggered via pull request August 31, 2023 12:55
Status Failure
Total duration 29m 42s
Artifacts 2

end2end-test.yml

on: pull_request
Matrix: e2e-playwright
Matrix: e2e-puppeteer
Report to GitHub
3m 17s
Report to GitHub
Fit to window
Zoom out
Zoom in

Annotations

14 errors and 4 notices
Puppeteer - 3: packages/e2e-tests/specs/editor/various/links.test.js#L813
TimeoutError: waiting for function failed: timeout 30000ms exceeded at new WaitTask (/home/runner/work/gutenberg/gutenberg/node_modules/puppeteer-core/src/common/DOMWorld.ts:813:28) at DOMWorld.waitForFunction (/home/runner/work/gutenberg/gutenberg/node_modules/puppeteer-core/src/common/DOMWorld.ts:728:22) at Frame.waitForFunction (/home/runner/work/gutenberg/gutenberg/node_modules/puppeteer-core/src/common/FrameManager.ts:1368:28) at Page.waitForFunction (/home/runner/work/gutenberg/gutenberg/node_modules/puppeteer-core/src/common/Page.ts:3358:29) at waitForFunction (/home/runner/work/gutenberg/gutenberg/packages/e2e-tests/specs/editor/various/links.test.js:21:14) at Object.waitForURLFieldAutoFocus (/home/runner/work/gutenberg/gutenberg/packages/e2e-tests/specs/editor/various/links.test.js:456:9) at runMicrotasks (<anonymous>) at processTicksAndRejections (node:internal/process/task_queues:96:5)
Puppeteer - 3: packages/e2e-tests/specs/editor/various/links.test.js#L755
Error: expect(received).toBeNull() Received: {"_client": {"_callbacks": [Map], "_connection": [Connection], "_sessionId": "11190EC8D97C0C80512AEBC655F0D676", "_targetType": "page", "emitter": [Object], "eventsMap": [Map]}, "_context": {"_client": [CDPSession], "_contextId": 225, "_contextName": "", "_world": [DOMWorld]}, "_disposed": false, "_frame": {"_childFrames": [Set], "_client": [CDPSession], "_detached": false, "_frameManager": [FrameManager], "_id": "490596EAB01C79845E0ECBA4D1F8465A", "_lifecycleEvents": [Set], "_loaderId": "406DDC1FF74F08E4416A27AE74008366", "_mainWorld": [DOMWorld], "_name": undefined, "_parentFrame": null, "_secondaryWorld": [DOMWorld], "_url": "http://localhost:8889/wp-admin/post-new.php"}, "_frameManager": {"_client": [CDPSession], "_contextIdToContext": [Map], "_frames": [Map], "_isolatedWorlds": [Set], "_mainFrame": [Frame], "_networkManager": [NetworkManager], "_page": [Page], "_timeoutSettings": [TimeoutSettings], "emitter": [Object], "eventsMap": [Map]}, "_page": {"_accessibility": [Accessibility], "_client": [CDPSession], "_closed": false, "_coverage": [Coverage], "_emulationManager": [EmulationManager], "_fileChooserInterceptors": [Set], "_frameManager": [FrameManager], "_handlerMap": WeakMap {}, "_javascriptEnabled": true, "_keyboard": [Keyboard], "_mouse": [Mouse], "_pageBindings": [Map], "_screenshotTaskQueue": [TaskQueue], "_target": [Target], "_timeoutSettings": [TimeoutSettings], "_touchscreen": [Touchscreen], "_tracing": [Tracing], "_userDragInterceptionEnabled": false, "_viewport": [Object], "_workers": [Map], "emitter": [Object], "eventsMap": [Map]}, "_remoteObject": {"className": "HTMLDivElement", "description": "div.block-editor-link-control", "objectId": "-3728757499232447572.225.5", "subtype": "node", "type": "object"}} at Object.toBeNull (/home/runner/work/gutenberg/gutenberg/packages/e2e-tests/specs/editor/various/links.test.js:755:6) at runMicrotasks (<anonymous>) at processTicksAndRejections (node:internal/process/task_queues:96:5)
Puppeteer - 3: packages/e2e-tests/specs/editor/various/links.test.js#L23
Error: No node found for selector: button[aria-label="Link"] at assert (/home/runner/work/gutenberg/gutenberg/node_modules/puppeteer-core/src/common/assert.ts:23:21) at DOMWorld.click (/home/runner/work/gutenberg/gutenberg/node_modules/puppeteer-core/src/common/DOMWorld.ts:461:11) at runMicrotasks (<anonymous>) at processTicksAndRejections (node:internal/process/task_queues:96:5) at Object.<anonymous> (/home/runner/work/gutenberg/gutenberg/packages/e2e-tests/specs/editor/various/links.test.js:818:4)
Puppeteer - 3
Process completed with exit code 1.
[chromium] › editor/blocks/links.spec.js:11:2 › Links › can be created by selecting text and using keyboard shortcuts: test/e2e/specs/editor/blocks/links.spec.js#L74
1) [chromium] › editor/blocks/links.spec.js:11:2 › Links › can be created by selecting text and using keyboard shortcuts Error: expect(received).toMatchObject(expected) - Expected - 1 + Received + 1 Array [ Object { "attributes": Object { - "content": "This is <a href=\"https://wordpress.org/gutenberg\" target=\"_blank\" rel=\"noreferrer noopener\">Gutenberg</a>", + "content": "This is <a href=\"https://wordpress.org/gutenberg\">Gutenberg</a>", }, "name": "core/paragraph", }, ] Call Log: - Timeout 5000ms exceeded while waiting on the predicate 72 | 73 | // The link should have been inserted. > 74 | await expect.poll( editor.getBlocks ).toMatchObject( [ | ^ 75 | { 76 | name: 'core/paragraph', 77 | attributes: { at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/links.spec.js:74:3
[chromium] › editor/blocks/links.spec.js:11:2 › Links › can be created by selecting text and using keyboard shortcuts: test/e2e/specs/editor/blocks/links.spec.js#L60
1) [chromium] › editor/blocks/links.spec.js:11:2 › Links › can be created by selecting text and using keyboard shortcuts Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── TimeoutError: locator.click: Timeout 10000ms exceeded. =========================== logs =========================== waiting for getByLabel('Open in new tab') ============================================================ 58 | // Navigate to and toggle the "Open in new tab" checkbox. 59 | const checkbox = page.getByLabel( 'Open in new tab' ); > 60 | await checkbox.click(); | ^ 61 | 62 | // Toggle should still have focus and be checked. 63 | await expect( checkbox ).toBeChecked(); at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/links.spec.js:60:18
[chromium] › editor/blocks/links.spec.js:11:2 › Links › can be created by selecting text and using keyboard shortcuts: test/e2e/specs/editor/blocks/links.spec.js#L74
1) [chromium] › editor/blocks/links.spec.js:11:2 › Links › can be created by selecting text and using keyboard shortcuts Retry #2 ─────────────────────────────────────────────────────────────────────────────────────── Error: expect(received).toMatchObject(expected) - Expected - 1 + Received + 1 Array [ Object { "attributes": Object { - "content": "This is <a href=\"https://wordpress.org/gutenberg\" target=\"_blank\" rel=\"noreferrer noopener\">Gutenberg</a>", + "content": "This is <a href=\"https://wordpress.org/gutenberg\">Gutenberg</a>", }, "name": "core/paragraph", }, ] Call Log: - Timeout 5000ms exceeded while waiting on the predicate 72 | 73 | // The link should have been inserted. > 74 | await expect.poll( editor.getBlocks ).toMatchObject( [ | ^ 75 | { 76 | name: 'core/paragraph', 77 | attributes: { at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/links.spec.js:74:3
[chromium] › editor/blocks/links.spec.js:85:2 › Links › can update the url of an existing link: test/e2e/specs/editor/blocks/links.spec.js#L117
2) [chromium] › editor/blocks/links.spec.js:85:2 › Links › can update the url of an existing link TimeoutError: locator.fill: Timeout 10000ms exceeded. =========================== logs =========================== waiting for getByPlaceholder('Search or type url') ============================================================ 115 | // Edit link. 116 | await pageUtils.pressKeys( 'primary+k' ); > 117 | await page.getByPlaceholder( 'Search or type url' ).fill( '' ); | ^ 118 | await page.keyboard.type( 'wordpress.org' ); 119 | 120 | // Update the link. at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/links.spec.js:117:55
[chromium] › editor/blocks/links.spec.js:85:2 › Links › can update the url of an existing link: test/e2e/specs/editor/blocks/links.spec.js#L117
2) [chromium] › editor/blocks/links.spec.js:85:2 › Links › can update the url of an existing link Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── TimeoutError: locator.fill: Timeout 10000ms exceeded. =========================== logs =========================== waiting for getByPlaceholder('Search or type url') ============================================================ 115 | // Edit link. 116 | await pageUtils.pressKeys( 'primary+k' ); > 117 | await page.getByPlaceholder( 'Search or type url' ).fill( '' ); | ^ 118 | await page.keyboard.type( 'wordpress.org' ); 119 | 120 | // Update the link. at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/links.spec.js:117:55
[chromium] › editor/blocks/links.spec.js:85:2 › Links › can update the url of an existing link: test/e2e/specs/editor/blocks/links.spec.js#L117
2) [chromium] › editor/blocks/links.spec.js:85:2 › Links › can update the url of an existing link Retry #2 ─────────────────────────────────────────────────────────────────────────────────────── TimeoutError: locator.fill: Timeout 10000ms exceeded. =========================== logs =========================== waiting for getByPlaceholder('Search or type url') ============================================================ 115 | // Edit link. 116 | await pageUtils.pressKeys( 'primary+k' ); > 117 | await page.getByPlaceholder( 'Search or type url' ).fill( '' ); | ^ 118 | await page.keyboard.type( 'wordpress.org' ); 119 | 120 | // Update the link. at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/links.spec.js:117:55
[chromium] › editor/blocks/links.spec.js:149:2 › Links › toggle state of advanced link settings is preserved across editing links: test/e2e/specs/editor/blocks/links.spec.js#L195
3) [chromium] › editor/blocks/links.spec.js:149:2 › Links › toggle state of advanced link settings is preserved across editing links TimeoutError: locator.click: Timeout 10000ms exceeded. =========================== logs =========================== waiting for getByRole('region', { name: 'Editor content' }).getByRole('button', { name: 'Advanced' }) ============================================================ 193 | name: 'Advanced', 194 | } ) > 195 | .click(); | ^ 196 | 197 | // Move focus out of Link UI and into Paragraph block. 198 | await pageUtils.pressKeys( 'Escape' ); at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/links.spec.js:195:5
[chromium] › editor/blocks/links.spec.js:149:2 › Links › toggle state of advanced link settings is preserved across editing links: test/e2e/specs/editor/blocks/links.spec.js#L195
3) [chromium] › editor/blocks/links.spec.js:149:2 › Links › toggle state of advanced link settings is preserved across editing links Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── TimeoutError: locator.click: Timeout 10000ms exceeded. =========================== logs =========================== waiting for getByRole('region', { name: 'Editor content' }).getByRole('button', { name: 'Advanced' }) ============================================================ 193 | name: 'Advanced', 194 | } ) > 195 | .click(); | ^ 196 | 197 | // Move focus out of Link UI and into Paragraph block. 198 | await pageUtils.pressKeys( 'Escape' ); at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/links.spec.js:195:5
[chromium] › editor/blocks/links.spec.js:149:2 › Links › toggle state of advanced link settings is preserved across editing links: test/e2e/specs/editor/blocks/links.spec.js#L195
3) [chromium] › editor/blocks/links.spec.js:149:2 › Links › toggle state of advanced link settings is preserved across editing links Retry #2 ─────────────────────────────────────────────────────────────────────────────────────── TimeoutError: locator.click: Timeout 10000ms exceeded. =========================== logs =========================== waiting for getByRole('region', { name: 'Editor content' }).getByRole('button', { name: 'Advanced' }) ============================================================ 193 | name: 'Advanced', 194 | } ) > 195 | .click(); | ^ 196 | 197 | // Move focus out of Link UI and into Paragraph block. 198 | await pageUtils.pressKeys( 'Escape' ); at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/links.spec.js:195:5
[chromium] › editor/blocks/links.spec.js:237:2 › Links › can toggle link settings and save: test/e2e/specs/editor/blocks/links.spec.js#L267
4) [chromium] › editor/blocks/links.spec.js:237:2 › Links › can toggle link settings and save ──── Error: Timed out 5000ms waiting for expect(received).not.toBeChecked() Call log: - expect.not.toBeChecked with timeout 5000ms - waiting for getByLabel('Open in new tab') - waiting for getByLabel('Open in new tab') 265 | 266 | // expect settings for `Open in new tab` and `No follow` > 267 | await expect( page.getByLabel( 'Open in new tab' ) ).not.toBeChecked(); | ^ 268 | await expect( page.getByLabel( 'nofollow' ) ).not.toBeChecked(); 269 | 270 | // Toggle both of the settings at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/links.spec.js:267:60
🎭 Playwright Run Summary
1 skipped 204 passed (12.3m)
🎭 Playwright Run Summary
2 skipped 213 passed (15.5m)
🎭 Playwright Run Summary
223 passed (16.2m)
🎭 Playwright Run Summary
3 failed [chromium] › editor/blocks/links.spec.js:11:2 › Links › can be created by selecting text and using keyboard shortcuts [chromium] › editor/blocks/links.spec.js:85:2 › Links › can update the url of an existing link ─ [chromium] › editor/blocks/links.spec.js:149:2 › Links › toggle state of advanced link settings is preserved across editing links 1 flaky [chromium] › editor/blocks/links.spec.js:237:2 › Links › can toggle link settings and save ───── 213 passed (19.1m)

Artifacts

Produced during runtime
Name Size
failures-artifacts Expired
32.8 MB
flaky-tests-report Expired
7.26 KB