Add note regarding WordPress-VIP ruleset

[GaryJones]

Quick and temporary workaround to reduce the chance of new folks using it:

I honestly believe this ruleset is damaging, and the longer it remains the higher the chances of new people finding it and using it.

See #1309.

[jrfnl]

• It was originally for [WordPress.com VIP coding requirements] - is this sentence missing the word intended or is it just me ?
• I'm a bit wary about using the word soon in this context all things considering.

[GaryJones]

It was originally for [WordPress.com VIP coding requirements] - is this sentence missing the word intended or is it just me ?

Added, and clarified further.

I'm a bit wary about using the word soon in this context all things considering.

Changed to "in due course".

[jrfnl]

• this is no longer used or recommended by the WordPress.com VIP team or their clients. - Do you mean for their clients ?

I'm wondering if we shouldn't also remove the VIP ruleset and the VIP sniffs - <exclude name="WordPress.VIP" /> - from the WordPress ruleset in this PR.
That way the WPCS side of things would be completely covered by this PR.

Opinions ?

[GaryJones]

This was meant as a quick workaround whilst the finer points of how such a removal would be done. It was building on Tom's information that the VIP team no longer use it, or recommend it to their clients.

I think making an actual change to the characteristics of WPCS, like removing the ruleset, should be its own PR, even if that includes a further change to this readme about its inclusion.

[JDGrimes]

Just to make sure that we are all on the same page, @jrfnl was suggesting that the WordPress.VIP sniffs be excluded from the WordPress ruleset, so that the VIP sniffs would no longer be used by WPCS by default—only if they were explicitly included via a custom ruleset.

I think that makes sense, as otherwise, I'd think a lot of folks would still end up using the VIP sniffs via the WordPress ruleset. It doesn't make sense to tell people not to use it, and then offer them a ruleset that includes it, IMO.

[tomjn]

I can say VIP doesn't recommend the ruleset fullstop, client or not client

[GaryJones]

Needs updating as per #1410.

See comments at https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/1410/files#r201158500

[jrfnl]

Closing as @GaryJones' textual improvements were implemented in #1410.