Deprecated the VIP sniff SuperGlobalInputUsageSniff

WordPress-VIP/ruleset.xml

@@ -246,6 +246,11 @@
 		<severity>0</severity>
 	</rule>
 
+	<!-- Prevent deprecation notice when the sniff is not explicitely included. -->
+	<rule ref="WordPress.VIP.SuperGlobalInputUsageSniff.DeprecatedSniff">
+		<severity>0</severity>
+	</rule>
+
 	<!-- Prevent deprecation notice when the sniff is not explicitely included. -->
 	<rule ref="WordPress.VIP.TimezoneChange.DeprecatedSniff">
 		<severity>0</severity>

WordPress/Sniffs/VIP/SuperGlobalInputUsageSniff.php

@@ -21,9 +21,32 @@
  * @since   0.3.0
  * @since   0.4.0  This class now extends WordPress_Sniff.
  * @since   0.13.0 Class name changed: this class is now namespaced.
+ *
+ * @deprecated 1.0.0  This sniff has been deprecated.
+ *                    This file remains for now to prevent BC breaks.
  */
 class SuperGlobalInputUsageSniff extends Sniff {
 
+	/**
+	 * If true, an error will be thrown; otherwise a warning.
+	 *
+	 * @var bool
+	 */
+	public $error = true;
+
+	/**
+	 * Keep track of whether the warnings have been thrown to prevent
+	 * the messages being thrown for every token triggering the sniff.
+	 *
+	 * @since 1.0.0
+	 *
+	 * @var array
+	 */
+	private $thrown = array(
+		'DeprecatedSniff'                 => false,
+		'FoundPropertyForDeprecatedSniff' => false,
+	);
+
 	/**
 	 * Returns an array of tokens this test wants to listen for.
 	 *
@@ -43,6 +66,24 @@ public function register() {
 	 * @return void
 	 */
 	public function process_token( $stackPtr ) {
+		if ( false === $this->thrown['DeprecatedSniff'] ) {
+			$this->thrown['DeprecatedSniff'] = $this->phpcsFile->addWarning(
+				'The "WordPress.VIP.SessionVariableUsageSniff" sniff has been deprecated. Please update your custom ruleset.',
+				0,
+				'DeprecatedSniff'
+			);
+		}
+
+		if ( ! empty( $this->exclude )
+			&& false === $this->thrown['FoundPropertyForDeprecatedSniff']
+		) {
+			$this->thrown['FoundPropertyForDeprecatedSniff'] = $this->phpcsFile->addWarning(
+				'The "WordPress.VIP.SessionVariableUsageSniff" sniff has been deprecated. Please update your custom ruleset.',
+				0,
+				'FoundPropertyForDeprecatedSniff'
+			);
+		}
+
 		// Check for global input variable.
 		if ( ! in_array( $this->tokens[ $stackPtr ]['content'], $this->input_superglobals, true ) ) {
 			return;

WordPress/Tests/VIP/SuperGlobalInputUsageUnitTest.php

@@ -37,6 +37,7 @@ public function getErrorList() {
 	 */
 	public function getWarningList() {
 		return array(
+			1  => 1,
 			3  => 1,
 			13 => 1,
 			15 => 1,