Dagger android #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 17, 2017 16:55
SpicyCactuar
suggested changes
Aug 31, 2017
networking/build.gradle
Outdated
| dependencies { | ||
| compile fileTree(dir: 'libs', include: ['*.jar']) | ||
|
|
||
| // Wolmo | ||
| compile 'com.github.Wolox:wolmo-core-android:v1.0.0' | ||
| compile 'com.github.Wolox:wolmo-core-android:dagger-android-SNAPSHOT' |
There was a problem hiding this comment.
We should change the dagger-android-SNAPSHOT to the corresponding version when merging the PR. Maybe put a TODO 🤔?
There was a problem hiding this comment.
Nice catch, I'll add it 😄
| */ | ||
| public abstract class NetworkingApplication extends WolmoApplication { | ||
| public class LoggingUtils { |
There was a problem hiding this comment.
Should we build a class just to return an HttpLoggingInterceptor?
If it provided several different Interceptors or something like that, i would be more in favor. But i believe this code can be inlined.
There was a problem hiding this comment.
I think I'll remove this class and let the client to create and configure a logger interceptor if they want. Do you think we should keep the library com.squareup.okhttp3:logging-interceptor?
|
@emalamela Done 😄 |
alvarez-fabian
assigned juanignaciomolina and SpicyCactuar and unassigned alvarez-fabian
alvarez-fabian
force-pushed
the
dagger-android
branch
from
79c77d5
to
dbe1648
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update
wolmo-networkingto make it compatible with dagger.NetworkComponentto build and configureRetrofitServices.GsonModuleto provide aGsoninstance and dependencies to build it.NetworkingModuleto provide aRetrofitinstance.OkHttpClientModuleto provideOkHttpClient, and add interceptors to it.NetworkingApplicationthat's not needed anymore.RetrofitServicesto move all the creation and configuration to the specific modules.Description
Applications that need to use
wolmo-networkdoesn't need anymore to extendNetworkingApplication.This library provides the modules to build and configure the dependencies of retrofit, Gson and OkHttp, it also provides a default
NetworkingComponentto simplify the creation and reduce configuration on common scenarios. For it to work you only need to provide it thebaseUrl, an optional list of interceptors to add tookHttpand an optional list ofgsontype adapters.We can find the following modules:
NetworkingComponentis a template component for simple uses, if the clients want to further customize it they can make a new Component and include the modules provided with this library or make their own.If you think we can separate this modules more please let me know so we can make this more modular.
All the modules and the component in this library uses
@NetworkingScopeto define a common scope.TODO