Add Color.Equals() override without casting.
#502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update scripts
Update for L1 and L2 scripts
RC1-1 final GitHub action edits
Remove external folder from sln
Currently, if someone wants to check for color equality they may do `color1.Equals(color2)`. This currently ends up calling the `Equals(object other)` which requires type checks and casting. This adds significant performance penalty, which adds up in some contexts (e.g. checking each pixel you are drawing isn't the designated transparent color). This can be worked around by using the `==` and `!=` overloads, but it's not obvious without looking at the source code that these are overloaded to be better optimized. Therefore, to help with the pit of success I've added an Equals overload that doesn't require casting, and significantly improves performance when called many times.
|
Thanks @KallDrexx ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if someone wants to check for color equality they may do
color1.Equals(color2). This currently ends up calling theEquals(object other)which requires type checks and casting. This adds significant performance penalty, which adds up in some contexts (e.g. checking each pixel you are drawing isn't the designated transparent color).This can be worked around by using the
==and!=overloads, but it's not obvious without looking at the source code that these are overloaded to be better optimized. Therefore, to help with the pit of success I've added an Equals overload that doesn't require casting, and significantly improves performance when called many times.