Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the XL Tank Sensor parsing #458

Merged
merged 3 commits into from
Nov 10, 2022
Merged

Fix the XL Tank Sensor parsing #458

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d5d4f4
Merge pull request #443 from WildernessLabs/develop
adrianstevens Nov 2, 2022
075909d
Fix the XL Tank Sensor parsing
bryancostanich Nov 10, 2022
d9b67cd
Merge branch 'develop' into maxbotix/XL_Tank_Sensor_LengthParse_Fix
adrianstevens Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions Source/Meadow.Foundation.Peripherals/Sensors.Distance.MaxBotix/Driver/MaxBotix.Serial.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Meadow.Hardware;
using System;
using Meadow.Hardware;
using Meadow.Units;

namespace Meadow.Foundation.Sensors.Distance
Expand Down Expand Up @@ -42,7 +43,7 @@ Length ReadSensorSerial()
}

private void SerialMessagePort_MessageReceived(object sender, SerialMessageData e)
{
{
//R###\n //cm
//R####\n //mm
//R####\n //cm
Expand All @@ -53,7 +54,16 @@ private void SerialMessagePort_MessageReceived(object sender, SerialMessageData
{ return; }

//strip the leading R
var value = double.Parse(message.Substring(1));
string cleaned = message.Substring(1);

// get index of space
var spaceIndex = message.FirstIndexOf(new char[] { ' ' });
if (spaceIndex > 0)
{
cleaned = cleaned.Substring(0, spaceIndex);
}

var value = double.Parse(cleaned);

Length.UnitType units = GetUnitsForSensor(sensorType);

Expand Down