Mcp23xxx updates #397
Merged
Mcp23xxx updates #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial classes weren't providing any benefit and were hindering testing. Code is a lot simpler without them
Involved a bit of rework to add more interfaces for testability
Tests cover Constructor, Properties, Initialize, Read methods. Todo: Write methods, Interrupts
This in theory should work, but I'm still having trouble getting the device to respond. Will come back to this once interrupts are working with I2C
- Use "edgefalling" instead of "edgerising" for interrupt. (Default configured setting for device) - Inputports now have their initial values set - Whole lot of logging added - Interrupt ports do work, but only once
- Any interrupt mode can be used now, as long as the same mode is used for all interrupt ports. - Interrupt handling for `McpDigitalInputPort`s now alerts if the pin is interrupted or if the pin's value does not match last state. This compensates for missed interrupts a lot more consistently. - Logging is now limited to init and port creation, which is where most important things happen anyway. - Also Logging SPI activity, but this a is bit more careful so as to not slow down with logging when it isnt needed. - Logging is now done via `McpLogger` static class, which has methods to enable/disable and change the output destination of logging. By default logging is disabled.
jorgedevs
approved these changes
Aug 19, 2022
|
|
||
| namespace ICs.IOExpanders.Mcp23x08_Input_Sample | ||
| { | ||
| public class MeadowApp : App<F7FeatherV1> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.