Feature/pwm freq #350
Merged
Feature/pwm freq #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Retargeting to develop |
| @@ -168,9 +168,9 @@ public bool IsOn | |||
| Voltage blueLedForwardVoltage, | |||
| CommonType commonType = CommonType.CommonCathode) : | |||
| this( | |||
| device.CreatePwmPort(redPwmPin), | |||
There was a problem hiding this comment.
Instead of defining DefaultFrequency in every peripheral driver could we just create a CreatePwmPort overload that just takes a single param?
There was a problem hiding this comment.
Ah I see you have different values for each peripheral .... that makes sense
| @@ -41,11 +53,11 @@ public PiezoSpeaker(IPwmPort port) | |||
| /// </summary> | |||
| /// <param name="frequency">The frequency in hertz of the tone to be played</param> | |||
| /// <param name="duration">How long the note is played in milliseconds, if durration is 0, tone plays indefinitely</param> | |||
| public async Task PlayTone(float frequency, int duration = 0) | |||
| public async Task PlayTone(Frequency frequency, int duration = 0) | |||
There was a problem hiding this comment.
We should unitize PiezoSpeaker as well - I'll file an issue :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.