2 fixes for delegation: #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update clone delegation to not raise an exception if the delegator's KEL is not in local kevers - Fix event handling to walk the KEL to find an anchoring event if it exists. These changes close WebOfTrust#842 by allowing for a witness to return a KEL for a delegated AID without the AES couple for approved events and without the delegator's KEL. This is the expected behavior for a witness as it should not be assumed that a witness perform watcher functionality. Any validator will have to be introduced to the delegator or OOBI with the delegator before validating the KEL of the delegate. Signed-off-by: pfeairheller <pfeairheller@gmail.com>
m00sey
approved these changes
Aug 14, 2024
|
@pfeairheller With a quick read I don't think this quite fixes everything its close but it may introduce another problem. I will have a closer look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes close #842 by allowing for a witness to return a KEL for a delegated AID without the AES couple for approved events and without the delegator's KEL.
This is the expected behavior for a witness as it should not be assumed that a witness perform watcher functionality. Any validator will have to be introduced to the delegator or OOBI with the delegator before validating the KEL of the delegate.